Hey, Thats great and it worked for me - I created a PR on your behalf. Zoi, can u please review? https://github.com/apache/incubator-wayang/pull/300
@Biao, please add the valid Apache Software License 2 headers, see Wordcount fix · apache/incubator-wayang@4431aed (github.com) <https://github.com/apache/incubator-wayang/actions/runs/4735975917/jobs/8406911741?pr=300#step:6:141> ff Cheers, —Alex > On 18. Apr 2023, at 19:52, Biao Geng <[email protected]> wrote: > > Hi folks, > I have finished the step 1 proposed by @Zoi > Kaoudi<mailto:[email protected]>. > So, you can find the built binary files hers: > https://www.google.com/url?q=https://github.com/bgeng777/incubator-wayang/tree/wordcount_fix/tmpBinaries/wayang-0.6.1-SNAPSHOT&source=gmail-imap&ust=1682445157000000&usg=AOvVaw1oHka8SFQc3UKYAHxgjP7W > I also wrote a simple > tutorial<https://www.google.com/url?q=https://github.com/bgeng777/incubator-wayang/blob/wordcount_fix/Tutorial.md&source=gmail-imap&ust=1682445157000000&usg=AOvVaw3KEAVSGYPTSTUqy9UU0Mzh> > based on README in the project. It would be great if anyone else can follow > the instructions in the doc to verify the word count example. If there are > any problems, please let me know. > > Besides, there are some interesting discoveries: > > 1. We already have the wayang-assembly module, which would help us build > the binary easily. In fact, I directly used it in my wordcount_fix branch > instead of pushing my previous jars. > 2. Though the built binary files can work, it would still output some > annoying information, which I have mentioned in the > issue<https://www.google.com/url?q=https://github.com/apache/incubator-wayang/issues/282&source=gmail-imap&ust=1682445157000000&usg=AOvVaw34LIeGiMvoHFNEp2lwHUt7>. > I will spend some time later to figure out if we can avoid it. > > Best, > Biao Geng > > > From: Biao Geng <[email protected]> > Date: Tuesday, April 18, 2023 at 11:26 PM > To: [email protected] <[email protected]> > Subject: Re: What's the proper way to run Wayang's WordCount Example? > Hi there, > > Thanks a lot for your response and the discussion. > Zoi’s proposal makes senses to me. I can take care of the compressed file > with the binaries for the new release. I will also add a doc for that so you > can verify it at least by running the word count example. > I may take following steps: > > 1. I will create a fork based on current main branch(commitId is > d46f3c3<https://www.google.com/url?q=https://github.com/apache/incubator-wayang/commit/d46f3c3f0fb963c2ee2640f00a106042fba55431&source=gmail-imap&ust=1682445157000000&usg=AOvVaw0KR103oRbBWOAn_lLoacih>) > with workable jars for running the wordcount example. > 2. I will write a simple tutorial to show how to run the example locally. > I also create a > jira<https://www.google.com/url?q=https://issues.apache.org/jira/browse/WAYANG-48&source=gmail-imap&ust=1682445157000000&usg=AOvVaw0tJGfl2UkGmF1cW_PZWDrn> > to track the work. Once I am ready, I will update in this thread. > > Best, > Biao Geng > > > From: Jorge Arnulfo Quiané Ruiz <[email protected]> > Date: Monday, April 17, 2023 at 11:51 PM > To: [email protected] <[email protected]> > Subject: Re: What's the proper way to run Wayang's WordCount Example? > Welcome on board Biao and thanks a lot for your help to the project, pretty > much appreciated!!! > > I agree with the proposed plan by Zoi. Once we have points 1 and 2 (I will > also perform point 2) we will start point 3. > > Best, > Jorge > >> On 14 Apr 2023, at 14.44, Zoi Kaoudi <[email protected]> wrote: >> >> Great! >> So, I propose to do the following: >> >> 1. Biao creates the compressed file with the binaries for the new release >> 2. I get the file and test it in my machine >> >> 3. Alex initiates the release process >> How does this sound? >> >> Best-- >> Zoi >> >> Στις Παρασκευή 14 Απριλίου 2023 - 02:42:51 μ.μ. CEST, ο χρήστης Zoi Kaoudi >> <[email protected]> έγραψε: >> >> Great! >> So, I propose to do the following: >> >> 1. Biao creates the compressed file with the binaries for the new release2. >> I get the file and test it in my machine >> 3. Alex initiates the release process >> How does this sound? >> Best >> -- >> Zoi >> >> Στις Παρασκευή 14 Απριλίου 2023 - 11:40:36 π.μ. CEST, ο χρήστης Alexander >> Alten <[email protected]> έγραψε: >> >> Good point. >>> On 14. Apr 2023, at 11:05, Zoi Kaoudi <[email protected]> wrote: >>> >>> I think we should do a binary release first without changing anything so >>> that the installation problem is fixed asap. This won’t be a new release >>> but complementary to the current one. Isn’t that possible? Or is it >>> possible to just replace the current file we have with a new one? >> >> Yes, we need a new release. >> >>> Then, we can take care to remove Java 8 and graphchi in a new release. But >>> this requires more time. >> >> +1 >> >>> Best—Zoi >>> >>> >>> Sent from Yahoo Mail for iPhone >>> >>> >>> On Friday, April 14, 2023, 09:52, Alexander Alten <[email protected] >>> <mailto:[email protected]>> wrote: >>> >>> Hi, and welcome Biao :) >>> >>> Yes, we should certainly plan a new release as soon as we have finished the >>> cleanup process. From my point of view we should eliminate Java 8 support >>> due security concerns. I’m also in for to end support for GraphChi, since >>> this project is dead since 8 years. To end support for J8 and GraphChi I >>> think we need to clarify the reasons in the release notes. Maybe it’s a >>> good idea to start a new thread which contains the content of the next >>> release? Just to make sure that we have a clear path. >>> >>> Objections and comments are welcome, @community! >>> >>> —Alex >>> >>>> On 14. Apr 2023, at 09:40, Zoi Kaoudi <[email protected]> wrote: >>>> >>>> Yes, I totally agree that we need to correct the current release and >>>> provide the binaries and not the source code. >>>> I am also not very familiar with the release process but I think Alex >>>> and/or Chris could help with that.@Alex, what do you think? >>>> In the meantime, maybe you could add/modify the README instructions for >>>> someone that wants to clone and build wayang and run the wordcount >>>> locally? For example, I could also build it successfully in my laptop but >>>> then it's not clear what I have to do to be able to run the main class. >>>> >>>> Best >>>> -- >>>> Zoi >>>> >>>> Στις Παρασκευή 14 Απριλίου 2023 - 09:28:00 π.μ. CEST, ο χρήστης Biao >>>> Geng <[email protected]> έγραψε: >>>> >>>> Hi Zoi, >>>> Thanks for the response! I see the point that the command-line tool is for >>>> production and the library is for development. That's consistent with my >>>> use experience of big data engines like spark and flink. >>>> As for the issue >>>> <https://www.google.com/url?q=https://www.google.com/url?q%3Dhttps://www.google.com/url?q%253Dhttps://github.com/apache/incubator-wayang/issues/282%2526source%253Dgmail-imap%2526ust%253D1682062845000000%2526usg%253DAOvVaw2Z4shFYJDRBcxO-cFQAYtz%26source%3Dgmail-imap%26ust%3D1682067936000000%26usg%3DAOvVaw2HrQCr-TFdIaR9pWi8r0FP&source=gmail-imap&ust=1682445157000000&usg=AOvVaw0vHkl7Ko0mYRm0HSSsWKJB>, >>>> I >>>> found the discussion >>>> <https://www.google.com/url?q=https://www.google.com/url?q%3Dhttps://www.google.com/url?q%253Dhttps://lists.apache.org/thread/5czmqpzk5vmw06z258jg7p6d2r1y4c88%2526source%253Dgmail-imap%2526ust%253D1682062845000000%2526usg%253DAOvVaw0FEGBKyRWimgKhGwvhuDqu%26source%3Dgmail-imap%26ust%3D1682067936000000%26usg%3DAOvVaw1hioJ8F2lCcfVtFYmtvlLd&source=gmail-imap&ust=1682445157000000&usg=AOvVaw1m4D4wACfxT02JUaM_xkvi> >>>> and >>>> sure, I can help to solve the problem. But I believe my current solution is >>>> not what we really want in the long run, right? The key part is to correct >>>> the downloaded zip file so other new users do not need to debug by >>>> themselves to add missing jars. While I am not quite familiar with Wayand's >>>> release process, will there be someone else with more experience to figure >>>> it out? >>>> Then I can take care of the other parts like validating the new zip/tar >>>> file, improving the README or solving some other problems in the process. >>>> What do you think? >>>> >>>> Again, thanks for your help in the mailing list and the github issue. >>>> >>>> Best, >>>> Biao Geng >>>> >>>> Zoi Kaoudi <[email protected] <mailto:[email protected]>> >>>> 于2023年4月14日周五 03:32写道： >>>> >>>>> Dear Biao, >>>>> welcome to the Wayang community :) >>>>> It's great you could run Wayang and yes you are in the right direction. >>>>> There is no right way on how to use Wayang that is why in the issue I >>>>> suggested to have two different ways in the documentation. One is using >>>>> the >>>>> wayang-submit but it has to be with a prebuilt package that you can >>>>> download and then you just run your jobs. This is meant more for >>>>> production. The other is as you said like a library that you can use in >>>>> your java application when developing. >>>>> >>>>> As you already made it run, do you think you could take care of that issue >>>>> and Michalis could take care of a different issue.What do you think? >>>>> Best >>>>> --Zoi >>>>> >>>>> Στις Πέμπτη 13 Απριλίου 2023 - 05:55:39 μ.μ. CEST, ο χρήστης Biao Geng >>>>> <[email protected] <mailto:[email protected]>> έγραψε: >>>>> >>>>> Dear community, >>>>> >>>>> Thanks for your efforts for creating this project! I am new to Wayang and >>>>> want to follow instructions to run a quick demo. I finally managed to do >>>>> that and could see outputs like the following(I wrote some notes about the >>>>> process in this issue’s comment< >>>>> https://www.google.com/url?q=https://www.google.com/url?q%3Dhttps://www.google.com/url?q%253Dhttps://github.com/apache/incubator-wayang/issues/282%252523issuecomment-1507208045%2526source%253Dgmail-imap%2526ust%253D1682062845000000%2526usg%253DAOvVaw07ndTlXkUpbDXTuVHSNUGt%26source%3Dgmail-imap%26ust%3D1682067936000000%26usg%3DAOvVaw2X2G1wcJuRkyCm6fpuksdX&source=gmail-imap&ust=1682445157000000&usg=AOvVaw06CRhhCuIpDwEbMTgY2TgF >>>>>> ): >>>>> ``` >>>>> Found 689 words: >>>>> 91x the >>>>> 87x wayang >>>>> 68x apache >>>>> ``` >>>>> But in the process, I had to figure out some installation/running >>>>> problems, which makes me wondering if I am on the right direction: should >>>>> I >>>>> use wayang-submit or consider Wayang as a library(i.e. write java program >>>>> and build a fat jar)? Which one is recommended? >>>>> >>>>> Best, >>>>> Biao Geng >>>>> >>> >>> >>> -- >>> databloom AI, Inc. >>> >>> 3401 N. MIAMI AVE. STE 230 >>> 33127 Miami, Florida >>> United States >>> >>> >>> -- Please consider the environment before printing this >>> email -- >>> >>> >>> >>> Disclaimer: >>> The content of this message is confidential. If you >>> have received it by mistake, please inform us by an email reply and then >>> delete the message. It is forbidden to copy, forward, or in any way reveal >>> the contents of this message to anyone. The integrity and security of this >>> email cannot be guaranteed over the Internet. Therefore, the sender will >>> not be held liable for any damage caused by the message. >> >> >> -- >> databloom AI, Inc. >> >> 3401 N. MIAMI AVE. STE 230 >> 33127 Miami, Florida >> United States >> >> >> -- Please consider the environment before printing this >> email -- >> >> >> >> Disclaimer: >> The content of this message is confidential. If you >> have received it by mistake, please inform us by an email reply and then >> delete the message. It is forbidden to copy, forward, or in any way reveal >> the contents of this message to anyone. The integrity and security of this >> email cannot be guaranteed over the Internet. Therefore, the sender will >> not be held liable for any damage caused by the message. >> >> -- databloom AI, Inc. 3401 N. MIAMI AVE. STE 230 33127 Miami, Florida United States -- Please consider the environment before printing this email -- Disclaimer: The content of this message is confidential. If you have received it by mistake, please inform us by an email reply and then delete the message. It is forbidden to copy, forward, or in any way reveal the contents of this message to anyone. The integrity and security of this email cannot be guaranteed over the Internet. Therefore, the sender will not be held liable for any damage caused by the message.
