Hi Christian,
yes, there is may be some old JS-code. But far as I know the script is
also used on other pages some don't remove the code until a larger
examination.
The bug was in
case "Windows": if (getLanguage() == "da") return "win"; else return "winjre";
but is has to be "winwjre".
Have you verified your change after checkin? I don't think so. Inside the
CVS-log you can see that the Danish-one-click problem was fixed before. My
fault was not to cc [EMAIL PROTECTED]
Kind regards,
Frank
Christian Lohmaier schrieb:
Hi Frank,
On Wed, Jul 30, 2008 at 11:59 AM, Christian Lohmaier
<[EMAIL PROTECTED]> wrote:
Hi Frank, *,
On Wed, Jul 30, 2008 at 11:20 AM, Frank Mau <[EMAIL PROTECTED]> wrote:
Hi Stefan,
found the errors. Someone made some changes last evening and damaged the
script. I'll fix it asap.
As it was me who changed the script, and the download still works for me,
I wonder what exactly I did break...
You did make a change now, but your commit-message doesn't make sense:
"fix bugs, please note that a switch is not equal to an indexof!!!"
Sure, but I did use the getPlatform() function, that does exaclty the
if ...indexof stuff.
So: Why does that break?
BTW:
The script is full of old stuff, dead code, duplication, etc. And it
is not documented in a useful manner.
ciao
Christian
--
OpenOffice.org wins Community Choice Awards in
'Best project', 'Best Enterprise Project' and 'Best Education-Project'
--
Sun Microsystems GmbH Dipl.-Ing. Frank Mau
Nagelsweg 55 Translation, IssueTracking, Web-tools
D-20097 Hamburg Phone: +49 (0)40 23646 894
Germany
http://www.sun.de
mailto:[EMAIL PROTECTED]
Registered Office: Sun Microsystems GmbH, Sonnenallee 1 ,D-85551
Kirchheim-Heimstetten
Commercial register of the Local Court of Munich: HRB 161028 Managing
Directors: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer Chairman of the
Supervisory Board: Martin Haering
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
