Here is the reason why we decided do RTC: We wanna make sure every modification is reviewed by another people. And avoid commit any feature without discuss with teammate. We use this to minimize the low-level bug. We do realize RTC will slow down the development，but we think it will be worth doing.
On Sat, Mar 11, 2017 at 8:41 AM, Niclas Hedhman <[email protected]> wrote: > Out of curiosity, why is "pull request model", normally called RTC (Review > Then Commit) in ASF legacy terminology? RTC has traditionally been used for > mature branches, say maintenance release branches (2.1.1, 2.1.2, 2.1.3) but > for 'development' branch or the new upcoming release, the dominant model is > CTR (Commit Then Review). > > We don't disallow RTC, but generally encourage to start as CTR, as we have > found that faster development is possible in CTR. > > What are your thoughts? Is this simply a left over from a corporate/github > environment, or has this been actively decided upon? > > > Cheers > Niclas > > On Fri, Mar 10, 2017 at 5:42 PM, 大诗胸 <[email protected]> wrote: > > > New contribute page: https://github.com/apache/incubator-weex/pull/88 > > > > > > On Thu, Mar 9, 2017 at 11:33 PM, Jinjiang Zhao <[email protected]> > > wrote: > > > > > Guys > > > > > > I have written an email to list the things we are working-in-progress > > and updated > > > the issue template of alibaba/weex repo to announce that we will stop > > > replying new issues any more from the end of this week. > > > > > > Additionally, I could build a page named "how to contribute" on our > > > website tomorrow. And then add the url to the issue template above. > > > > > > Thanks. > > > > > > Jinjiang > > > > > > On Mar 06, 2017, at 11:59 AM, Jinjiang Zhao <[email protected]> > wrote: > > > > > > Yes as you suspect, some of these PRs are from discussion in other ways > > > and some of them are from old pieces of work. 50% - 50% I think. But > yes > > > it's not OK of course. > > > > > > Guys I have some suggestions: > > > * First we should put more old information here, just like what plan we > > > have made or how many issues we are doing with. > > > * Migrate old alibaba/weex issues to apache gradually. > > > * Stop replying new issues in alibaba/weex (at least at a appropriate > > time > > > if not from now on). > > > * Encourage Chinese users moving here MORE. > > > * Try to guide more users abroad go to Apache directly (through > Twitter, > > > HackerNews ... I think). > > > * We should pay more attention here. > > > > > > Thanks. > > > > > > Jinjiang > > > > > > On Mar 03, 2017, at 06:29 PM, Niclas Hedhman <[email protected]> > wrote: > > > > > > Gang, > > > I see a massive amount of work (well done) being done and pull > requested > > > via GitHub. > > > > > > Are these old pieces of work that are pushed now, or is it new work? If > > the > > > latter, how does people know what to work on? > > > > > > Perhaps it is simply totally independent pieces, driven by personal > > > interest, BUT I SUSPECT that this is agreed upon at work, on some side > > > channel or otherwise. And that is NOT OK. > > > > > > Apache projects are expected to have discussions on features and fixes > on > > > the mailing list. As the saying goes around here; "If it didn't happen > on > > > the mailing list, it didn't happen!" > > > > > > Additionally, all communication in GitHub Pull Requests could disappear > > > tomorrow. The project's history would be gone as a result. No records > of > > > anything, other than the commit messages. > > > > > > So, everyone, I know this is difficult, especially since most of you > are > > > Chinese, probably with limited English fluency. But we need to get the > > > discussion going HERE... not at work, not on WeChat, not on Slack, not > on > > > GitHub or any other medium... HERE. > > > > > > > > > Thanks for listening > > > -- > > > Niclas Hedhman, Software Developer > > > http://polygene.apache.org <http://zest.apache.org> - New Energy for > > Java > > > > > > > > > > > > -- > > sospartan > > Phone:13588488290 > > HangZhou > > > > > > -- > Niclas Hedhman, Software Developer > http://polygene.apache.org <http://zest.apache.org> - New Energy for Java > -- sospartan Phone:13588488290 HangZhou
