Github user YorkShen commented on a diff in the pull request:

    https://github.com/apache/incubator-weex/pull/104#discussion_r106094395
  
    --- Diff: android/sdk/src/main/java/com/taobao/weex/dom/WXDomHandler.java 
---
    @@ -319,24 +275,41 @@ public boolean handleMessage(Message msg) {
     
       public static class MsgType {
    --- End diff --
    
    DomHandler有些冗余,消息会经过domModule -> 
domManger->domHandler->domManger这个序列传
递,消息在domManager和DomHandler之间扔来扔去。
    
    建议
    
    1. DomManger实现Handler.Callback
    1. `WXDomHandler.handleMessage`移动到`DomManger.handleMessage`
    1. DomHandler中仅保留` public static class MsgType `这个内
部静态类


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to