Github user bluebird78999 commented on a diff in the pull request:

    https://github.com/apache/incubator-weex/pull/233#discussion_r110566222
  
    --- Diff: ios/sdk/WeexSDK/Sources/Module/WXPickerModule.m ---
    @@ -213,8 +293,38 @@ - (NSString *)pickerView:(UIPickerView *)pickerView 
titleForRow:(NSInteger)row f
     - (void)pickerView:(UIPickerView *)pickerView didSelectRow:(NSInteger)row 
inComponent:(NSInteger)component
     {
         self.index = row;
    +    if(self.selectionColor) {
    +        UILabel *labelSelected = (UILabel*)[pickerView viewForRow:row 
forComponent:component];
    +        [labelSelected 
setBackgroundColor:self.selectionColor?self.selectionColor:[UIColor 
whiteColor]];
    +    }
    --- End diff --
    
    what's the background color of labelSelected? when self.selectionColor is 
nil.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to