[
https://issues.apache.org/jira/browse/WEEX-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242525#comment-16242525
]
ASF GitHub Bot commented on WEEX-96:
------------------------------------
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/839
<!--
0 failure:
2 warning: No Changelog chan..., This PR should up...
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
<tr>
<td>:warning:</td>
<td>This PR should update related documents as well. </td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>danger test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a
href="http://github.com/danger/danger-js/";>dangerJS</a>
</p>
> Timer exposed on JSContext can not clear and it has potential crash switching
> globalQueue
> -----------------------------------------------------------------------------------------
>
> Key: WEEX-96
> URL: https://issues.apache.org/jira/browse/WEEX-96
> Project: Weex
> Issue Type: Bug
> Reporter: xingZhang
> Assignee: Adam Feng
> Priority: Critical
>
> 1. timer can not be clear
> As the WXJSCoreBridge file in [line
> 544](https://github.com/apache/incubator-weex/blob/master/ios/sdk/WeexSDK/Sources/Bridge/WXJSCoreBridge.m#L544)
> shows the code, the appId is a string , so it will never be cleared.
> 2. timer execute js function in global queue may have potential crash, it had
> better execution in current thread.
> WXJSCoreBridge
> https://github.com/apache/incubator-weex/blob/master/ios/sdk/WeexSDK/Sources/Bridge/WXJSCoreBridge.m#L535
> 3. timerId will always be 1, not auto-increment as the count of timer
> increasing
> https://github.com/apache/incubator-weex/blob/master/ios/sdk/WeexSDK/Sources/Bridge/WXJSCoreBridge.m#L513
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
