+1. I also think it's a good idea to remove render and framework folders. But I will do it step by step.
(1). I have sent a PR (https://github.com/apache/incubator-weex/pull/955) to remove all legacy .we examples. (2). The next will be the legacy web-render and vue-render. (3). And then, all source code of frameworks and its build scripts should be removed. (4). At last, adjust the file structure of js frameworks. "html5" is not a reasonable name, use "runtime" is fine. Now (1) is working in progress, I think you can start to do (2) now, and don't forget to remove the useless build scripts. Best Regards, Hanks 2017-12-22 15:25 GMT+08:00 He Sai <[email protected]>: > Yes.. About that, I think we should have more discussion on not just > renders but all the js codes in 'html5' folder, because there may be other > legacy codes we might want to remove or archive. > > Firstly, the codes in html5/render/ include three different web renderer. > They should be removed, but the render/native is just a entry file for > frameworks. Maybe the native render should be moved to the html5/frameworks > as well. > > Secondly, should we remove it once for all, or should we just archive it > into the path of html5/render/legacy ? Since the way we dealing with the > old js-framework is like this. > > At last, what we do here is to clear out the DSL layer code, making weex > more concentrative and foucs on the core SDK and js-runtime, so that our > main project structure could be much clearer and more lightweight. > > I tend to remove all the codes in html5 including frameworks and renders, > move runtime codes into a 'runtime' path, and import whichever js-framework > into that runtime codes from npm packages. > > The structure might be like this: > > ``` > - android > - ios > - <del>html5</del> > - runtime (new) / all the js runtime code here... > - ... > ``` > > > > > 2017-12-22 14:17 GMT+08:00 Hanks Zhang <[email protected]>: > > > I noticed that the weex-vue-render have already been moved to > > https://github.com/weexteam/weex-vue-render > > > > So, I think the source code of it should be removed from the > > [apache/incubator-weex] repo. I created an issue to track it: > > https://issues.apache.org/jira/browse/WEEX-181 > > > > > > > > 2017-12-19 23:42 GMT+08:00 He Sai <[email protected]>: > > > > > @Jonathan Dong, Great, Thanks ! I'll transfer it into weexteam group > > soon. > > > > > > 2017-12-19 19:04 GMT+08:00 Jonathan Dong < > [email protected] > > >: > > > > > > > That is nice. I can help to create a repo in > > https://github.com/weexteam > > > > to host the codes here instead of using a personal github account. > > > > > > > > On 19 Dec 2017, 5:52 PM +0800, He Sai <[email protected]>, wrote: > > > > I think it's better to separate it from this repo. It's more like a > DSL > > > > layer stuff, a > > > > javascript framework to run the dot vue file on web platform, not a > > > feature > > > > of > > > > weex SDK it self. Since the rax DSL framework is not included in this > > > repo, > > > > it's > > > > more or less the same. > > > > > > > > I have already created a new repo for these codes, with building > > scripts > > > > and > > > > test cases: > > > > > > > > https://github.com/MrRaindrop/weex-vue-render > > > > > > > > The main project in this repo should be more focusing and cleaner, > > > > and the render codes in html5 folder could all be removed later. > > > > > > > > 2017-12-19 17:31 GMT+08:00 Hanks Zhang <[email protected]>: > > > > > > > > The "weex-vue-render" is a component and module library for Vue.js. > It > > > > enables pages written in Weex + Vue to run on the Web platform. It > can > > be > > > > used to downgrade the weex native pages to web pages. > > > > > > > > However, I think this package should separate from the incubator-weex > > > repo. > > > > > > > > Because it doesn't rely on any code of WeexSDK, and WeexSDK doesn't > > rely > > > on > > > > any code of weex-vue-render neither. Even the vue framework itself is > > > > separated from the incubator-weex repo, weex require it as a > > dependency, > > > > not to mention that weex-vue-render is not a part of WeexSDK. > > > > > > > > Moreover, weex-vue-render also required many web dependencies which > > could > > > > not be used in WeexSDK. I think it's a better to keep the source code > > of > > > > incubator-weex more simple and move the weex-vue-render and its > > > > dependencies to a separate repo. > > > > > > > > > > > > > > > > > > > > -- > > > > -------------------------------- > > > > Best Wishes！ > > > > _danz > > > > > > > > > > > > > > > > -- > > > -------------------------------- > > > Best Wishes！ > > > _danz > > > > > > > > > -- > -------------------------------- > Best Wishes！ > _danz >
