[
https://issues.apache.org/jira/browse/WEEX-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16335549#comment-16335549
]
ASF GitHub Bot commented on WEEX-200:
-------------------------------------
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/1000
<!--
0 failure:
2 warning: No Changelog chan..., This PR should up...
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
<tr>
<td>:warning:</td>
<td>This PR should update related documents as well. </td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>danger test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a
href="http://github.com/danger/danger-js/";>dangerJS</a>
</p>
> deprecate WXCallback and WXModuleCallback callback type
> --------------------------------------------------------
>
> Key: WEEX-200
> URL: https://issues.apache.org/jira/browse/WEEX-200
> Project: Weex
> Issue Type: Bug
> Components: iOS
> Reporter: xingZhang
> Assignee: xingZhang
> Priority: Major
>
> As iOS developers knows, we cannot distinguish the block by its params
> count, but it has been a time we use the default value of block parameter, I
> find out that the default value could be dirty data.
>
> here is the callback type definition.
> typedef void (^WXCallback)(_Nonnull id result)
> typedef void (^WXKeepAliveCallback)(_Nonnull id result, BOOL keepAlive);
>
> when the method called, weexSDK will set the callback according to the
> @encode result,
> but these two type's encode result are all "?", see more encode result from
> Apple Documents
> [https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/ObjCRuntimeGuide/Articles/ocrtTypeEncodings.html]
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
