[jira] [Commented] (WEEX-267) monitor the frequency of module invoke

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/WEEX-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417232#comment-16417232
 ] 

ASF GitHub Bot commented on WEEX-267:
-------------------------------------

Github user CYJB commented on a diff in the pull request:

    https://github.com/apache/incubator-weex/pull/1090#discussion_r177723438
  
    --- Diff: ios/sdk/WeexSDK/Sources/Protocol/WXAppMonitorProtocol.h ---
    @@ -54,4 +54,8 @@
     
     - (void)commitAppMonitorAlarm:(NSString *)pageName monitorPoint:(NSString 
*)monitorPoint success:(BOOL)success errorCode:(NSString *)errorCode 
errorMsg:(NSString *)errorMsg arg:(NSString *)arg;
     
    +@optional
    +
    +- (void)commitMonitorWithPage:(NSString *)pageName withPoint:(NSString 
*)monitorPoint withArgs:(NSDictionary *)args;
    --- End diff --
    
    Yes, that is better


> monitor the frequency of module invoke
> --------------------------------------
>
>                 Key: WEEX-267
>                 URL: https://issues.apache.org/jira/browse/WEEX-267
>             Project: Weex
>          Issue Type: Improvement
>          Components: iOS
>            Reporter: xingZhang
>            Assignee: xingZhang
>            Priority: Major
>
> add an extra method for monitor protocol instead of commit the frequency of 
> module usage in monitor alarm



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)