[ 
https://issues.apache.org/jira/browse/WEEX-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429992#comment-16429992
 ] 

ASF GitHub Bot commented on WEEX-282:
-------------------------------------

GitHub user win80540 opened a pull request:

    https://github.com/apache/incubator-weex/pull/1105

    [WEEX-282][iOS] update layout system to support rtl direction

    Update WXComponent+layout.m to support CSS "direction:rtl".
    Few languages such as Arabic, Hebrew, or Persian are written from Right to 
Left, but weex not support RTL layouts. To handle them. Since this PR merged, 
we can use weex for RTL languages.
    
    
    Modified WXComponent+Layout.m:
        1.set direction value to  cssNode
        2.setNeedLayout changed to trigger sibling component recalculate 
cssNode->layout
    
    Modified WXConvert.h/m:
        add convert for "direction"
    
    Modified WXConvertTests.m:
        add Tests for convert direction

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/win80540/incubator-weex ios-feature-RTL-layout

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/1105.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1105
    
----
commit 487b6924c9d200c315c96104c49f5f718aae0c5a
Author: Klueze <tiankai.tk@...>
Date:   2018-04-08T09:37:00Z

    [WEEX-282][iOS] update layout system to support rtl direction
    
    Modified WXComponent+Layout.m:
        1.set direction value to  cssNode
        2.setNeedLayout changed to trigger sibling component recalculate 
cssNode->layout
    
    Modified WXConvert.h/m:
        add convert for "direction"
    
    Modified WXConvertTests.m:
        add Tests for convert direction

----


> support CSS "direction:rtl"
> ---------------------------
>
>                 Key: WEEX-282
>                 URL: https://issues.apache.org/jira/browse/WEEX-282
>             Project: Weex
>          Issue Type: New Feature
>          Components: iOS
>            Reporter: KAI TIAN
>            Assignee: xingZhang
>            Priority: Major
>              Labels: pull-request-available
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Update WXComponent+layout.m to support CSS "direction:rtl".
> Few languages such as Arabic, Hebrew, or Persian are written from Right to 
> Left, but weex not support RTL layouts. To handle them. Since this PR merged, 
> we can use weex for RTL languages.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to