[
https://issues.apache.org/jira/browse/WEEX-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462230#comment-16462230
]
ASF GitHub Bot commented on WEEX-333:
-------------------------------------
GitHub user acton393 opened a pull request:
https://github.com/apache/incubator-weex/pull/1144
[WEEX-333][iOS] add protection for bezierPath contains nan point.
[WEEX-333][iOS] add protection for bezierPath contains nan point.
Bug:333
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/acton393/incubator-weex iOS-bezier-exception
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/1144.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1144
----
commit e56aed9ec4a265536824eb7d7c597e28730c7299
Author: acton393 <zhangxing610321@...>
Date: 2018-05-03T09:58:21Z
[WEEX-333][iOS] add protection for bezierPath contains nan point.
Bug:333
----
> clip image using bezier path crash in iOS 8
> ---------------------------------------------
>
> Key: WEEX-333
> URL: https://issues.apache.org/jira/browse/WEEX-333
> Project: Weex
> Issue Type: Improvement
> Reporter: xingZhang
> Assignee: xingZhang
> Priority: Major
>
> {code:java}
> 0 libsystem_kernel.dylib 0x0000000197b07270 __pthread_kill :8 (in
> libsystem_kernel.dylib)
> 1 libsystem_c.dylib 0x0000000197a7eb18 _abort :112 (in libsystem_c.dylib)
> 2 libsystem_c.dylib 0x0000000197a53a3c __assert_rtn :92 (in libsystem_c.dylib)
> 3 CoreGraphics 0x0000000186e75b84 _CGPathMoveToPoint :192 (in CoreGraphics)
> 4 UIKit 0x000000018b597a10 -[UIBezierPath moveToPoint:] :36 (in UIKit)
> 5 app 0x00000001031737f4 +[UIBezierPath(Weex)
> wx_bezierPathWithRoundedRect:topLeft:topRight:bottomLeft:bottomRight:]
> UIBezierPath+Weex.m:40 (in app)
> 6 app 0x00000001031ba9f0 -[WXImageComponent _clipsToBounds]
> WXImageComponent.m:557 (in app)
> 7 app 0x00000001031b8094 -[WXImageComponent viewDidLoad]
> WXImageComponent.m:284 (in app)
> 8 app 0x0000000103149654 -[WXComponent view] WXComponent.mm:446 (in app)
> {code}
>
> we need try to protect the nan point in bezier path.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
