[
https://issues.apache.org/jira/browse/WEEX-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465216#comment-16465216
]
ASF GitHub Bot commented on WEEX-337:
-------------------------------------
GitHub user seewhy93 opened a pull request:
https://github.com/apache/incubator-weex/pull/1149
* [WEEX-337] [jsfm] enable weex.supports return correctly when name
contains '-'
weex.supports can't distinguish component or module when their name
contains '-',
and it always return null.
example: http://dotwe.org/vue/26b73776ae3e34c4335491ce40e89e57
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/seewhy93/incubator-weex
jsfm-bugfix-weexsupports
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/1149.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1149
----
commit 224a6e82437cb7fab2fa58684b6286e774d3f916
Author: seewhy <seewhy163@...>
Date: 2018-05-06T14:26:31Z
* [jsfm] modify regex to enable component name contains '-'
----
> weex.supports return null when component name contains character '-'
> --------------------------------------------------------------------
>
> Key: WEEX-337
> URL: https://issues.apache.org/jira/browse/WEEX-337
> Project: Weex
> Issue Type: Bug
> Components: JSFM
> Affects Versions: 0.18
> Reporter: seewhy
> Assignee: Hanks Zhang
> Priority: Major
>
> weex.supports return null when component name contains character '-'
> for example:
> {code:java}
> weex.supports('@component/recycle-list')
> {code}
> should return true, but it returns null now.
> test case:
> http://dotwe.org/vue/26b73776ae3e34c4335491ce40e89e57
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)