[ 
https://issues.apache.org/jira/browse/WEEX-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469990#comment-16469990
 ] 

ASF GitHub Bot commented on WEEX-335:
-------------------------------------

Github user acton393 commented on a diff in the pull request:

    https://github.com/apache/incubator-weex/pull/1145#discussion_r187253448
  
    --- Diff: ios/sdk/WeexSDK/Sources/Layout/WXComponent+Layout.mm ---
    @@ -163,6 +165,13 @@ - (NSUInteger)_childrenCountForLayout
     - (void)_frameDidCalculated:(BOOL)isChanged
     {
         WXAssertComponentThread();
    +    if (isChanged) {
    +        CGFloat mainScreenWidth = [[UIScreen mainScreen] 
bounds].size.width;
    +        CGFloat mainScreenHeight = [[UIScreen mainScreen] 
bounds].size.height;
    +        if (mainScreenHeight/2 < _calculatedFrame.size.height && 
mainScreenWidth/2 < _calculatedFrame.size.width) {
    +            [self weexInstance].performance.cellExceedNum++;
    --- End diff --
    
    they are not all cell components


> [iOS] fix performance point && add errorType/errorGroup
> -------------------------------------------------------
>
>                 Key: WEEX-335
>                 URL: https://issues.apache.org/jira/browse/WEEX-335
>             Project: Weex
>          Issue Type: New Feature
>          Components: iOS
>            Reporter: peihan
>            Assignee: xingZhang
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to