[ 
https://issues.apache.org/jira/browse/WEEX-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511020#comment-16511020
 ] 

ASF GitHub Bot commented on WEEX-459:
-------------------------------------

GitHub user wqyfavor opened a pull request:

    https://github.com/apache/incubator-weex/pull/1265

    [WEEX-459][iOS] Fix crash if template not registered for recycle list…

    … on iOS.
    
    First of all, thank you for your contribution! 
    
    Please makes sure that these checkboxes are checked before submitting your 
PR, thank you!
    
    <!-- 
    How to use github markdown?
    ### checkable example
    - [x] checked
    - [ ] not checked
    More github Markdown info to see 
https://guides.github.com/features/mastering-markdown/
    -->
    
    CheckList:
    
    **if** *isBugFix* **:**
    
      * [ ] Make sure that you add at least one unit test for the bug which you 
had fixed.
    
    **elif** *isNewFeature* **:**
    
      * [ ] Update API docs for the component.
      * [ ] Update/Add demo to demonstrate new feature.
      * [ ] Update test scripts for the feature.
      * [ ] Add unit tests for the feature.
    
    <!--
    (请在***提交***前删除这段描述)
    
    Notes: Weex will move into Apache Software Foundation (ASF) on Feb 24 2017.
    
    Our new GitHub repo is https://github.com/apache/incubator-weex
    
    After Feb 24 2017, we only accept pull requests from 
https://github.com/apache/incubator-weex
    
    Thank you for your support.
    
    ----
    
    注意:Weex 将于 2017-02-24 迁移至 Apache 基金会
    
    届时我们会使用新的 GitHub 仓库:https://github.com/apache/incubator-weex 并在那里继续接受大家的 
pull request。
    
    更多详情请关注:https://github.com/weexteam/article/issues/130
    
    感谢理解和支持
    
    -->
    
    <!--
    (请在***提交***前删除这段描述)
    It's ***RECOMMENDED*** to submit typo fix, new demo, tiny bugfix and large 
feature to `master` branch.
        
    See [Branch 
Strategy](https://github.com/alibaba/weex/blob/dev/CONTRIBUTING.md#branch-management)
 for more detail.
    
    ----
    
    错别字修改、新 demo、较小的 bugfix、甚至较大的功能都可以直接提到 `master` 分支;
    
    查看完整的[分支策略 
(英文)](https://github.com/alibaba/weex/blob/dev/CONTRIBUTING.md#branch-management)。
    
    -->


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wqyfavor/incubator-weex 
fix-recyclelist-unreg-cell

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/1265.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1265
    
----
commit ccaafb6b4d347a55b8b04e9c5ec15359937cffea
Author: 神漠 <qianyuan.wqy@...>
Date:   2018-06-13T12:08:12Z

    [WEEX-459][iOS] Fix crash if template not registered for recycle list on 
iOS.

----


> Crash if template not registered for recycle list on iOS
> --------------------------------------------------------
>
>                 Key: WEEX-459
>                 URL: https://issues.apache.org/jira/browse/WEEX-459
>             Project: Weex
>          Issue Type: Bug
>          Components: iOS
>    Affects Versions: 0.12
>            Reporter: Wang Qianyuan
>            Assignee: xingZhang
>            Priority: Major
>
> RecycleList on iOS is based on UICollectionView. If not registered 
> class(templateType), [_collectionView 
> dequeueReusableCellWithReuseIdentifier:templateType forIndexPath:indexPath] 
> will crash.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to