[
https://issues.apache.org/jira/browse/WEEX-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16523373#comment-16523373
]
ASF GitHub Bot commented on WEEX-474:
-------------------------------------
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/1292
<!--
0 failure:
1 warning: No Changelog chan...
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>danger test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a
href="http://github.com/danger/danger-js/";>dangerJS</a>
</p>
> Toast ,crash!
> -------------
>
> Key: WEEX-474
> URL: https://issues.apache.org/jira/browse/WEEX-474
> Project: Weex
> Issue Type: Bug
> Components: Android
> Affects Versions: 0.16, 0.18
> Reporter: 武晨
> Assignee: codefurture
> Priority: Blocker
> Fix For: 0.18
>
>
> when the app's WXInstance destroy, but Weex page call toast()，sometimes app
> crash, because null point exception *context is null !!!*, inside toast().
>
> code class *WXModalUIModule*:
> @JSMethod(uiThread = true)
> public void toast(String param) {
> String message = "";
> int duration = Toast.LENGTH_SHORT;
> if (!TextUtils.isEmpty(param)) {
> try
> { param = URLDecoder.decode(param, "utf-8"); JSONObject jsObj =
> JSON.parseObject(param); message = jsObj.getString(MESSAGE); duration =
> jsObj.getInteger(DURATION); }
> catch (Exception e)
> { WXLogUtils.e("[WXModalUIModule] alert param parse error ", e); }
> }
> if (TextUtils.isEmpty(message))
> { WXLogUtils.e("[WXModalUIModule] toast param parse is null "); return; }
> if (duration > 3)
> { duration = Toast.LENGTH_LONG; }
> else
> { duration = Toast.LENGTH_SHORT; }
> if (toast == null) {
> {color:#ff0000}*//crash here!!!! sometime, mWXSDKInstance.getContext() is
> null !!!!*{color}
> t*oast = Toast.makeText(mWXSDKInstance.getContext(), message, duration);*
> } else
> { toast.setDuration(duration); toast.setText(message); }
> toast.setGravity(Gravity.CENTER, 0, 0);
> toast.show();
> }
>
> ps：when weex page closed, and wxSDKInstance destroy，but weex page still
> working on background like asynchronous request(network)，on this time.when
> the request is back, and call toast()，now context is null，bug show!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
