[jira] [Commented] (WEEX-520) [iOS] calibration performance of interactionTime

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/WEEX-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549017#comment-16549017
 ] 

ASF GitHub Bot commented on WEEX-520:
-------------------------------------

Github user wqyfavor commented on a diff in the pull request:

    https://github.com/apache/incubator-weex/pull/1343#discussion_r203650403
  
    --- Diff: ios/sdk/WeexSDK/Sources/Manager/WXComponentManager.mm ---
    @@ -374,45 +372,19 @@ - (void)removeComponent:(NSString *)ref
         [_indexDict removeObjectForKey:ref];
         
         __weak typeof(self) weakSelf = self;
    -    BOOL isFSCreateFinish = [self weexInstance].isJSCreateFinish;
         [self _addUITask:^{
             [WXTracingManager 
startTracingWithInstanceId:weakSelf.weexInstance.instanceId ref:ref 
className:nil name:nil phase:WXTracingBegin functionName:@"removeElement" 
options:@{@"threadName":WXTUIThread}];
             if (component.supercomponent) {
                 [component.supercomponent willRemoveSubview:component];
             }
             [component removeFromSuperview];
             [WXTracingManager 
startTracingWithInstanceId:weakSelf.weexInstance.instanceId ref:ref 
className:nil name:nil phase:WXTracingEnd functionName:@"removeElement" 
options:@{@"threadName":WXTUIThread}];
    -        [weakSelf onElementChange:isFSCreateFinish];
         }];
         
         [self _checkFixedSubcomponentToRemove:component];
         
     }
     
    -- (void)onElementChange:(BOOL)isFSCreateFinish
    -{
    -    if (!isFSCreateFinish) {
    -        return;
    -    }
    -    
    --- End diff --
    
    把本方法中使用的[self weexInstance]单独建个变量，减少oc调用。


> [iOS] calibration performance of interactionTime
> ------------------------------------------------
>
>                 Key: WEEX-520
>                 URL: https://issues.apache.org/jira/browse/WEEX-520
>             Project: Weex
>          Issue Type: Improvement
>            Reporter: peihan
>            Assignee: Adam Feng
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)