[jira] [Commented] (WEEX-495) WXSwizzleInstanceMethod实现重大bug

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/WEEX-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551915#comment-16551915
 ] 

ASF GitHub Bot commented on WEEX-495:
-------------------------------------

GitHub user xuyouyang opened a pull request:

    https://github.com/apache/incubator-weex/pull/1356

    [WEEX-495][iOS] Fix class_replaceMethod param error in 
WXSwizzleInstanceMethod

    Fix class_replaceMethod param error in WXSwizzleInstanceMethod

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuyouyang/incubator-weex ios-bugfix-WEEX-495

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/1356.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1356
    
----
commit a587da13ea076a8d36f94afaf8d0197701f5a567
Author: xuyouyang <xuyouyang1990@...>
Date:   2018-07-22T07:09:34Z

    [WEEX-495][iOS] Fix class_replaceMethod param error in 
WXSwizzleInstanceMethod.

----


> WXSwizzleInstanceMethod实现重大bug
> ------------------------------
>
>                 Key: WEEX-495
>                 URL: https://issues.apache.org/jira/browse/WEEX-495
>             Project: Weex
>          Issue Type: Bug
>          Components: iOS
>            Reporter: liuan
>            Assignee: xingZhang
>            Priority: Critical
>         Attachments: image-2018-07-06-17-06-47-091.png
>
>
> WXSwizzleInstanceMethod方法实现低级失误造成的重大bug，如果不修改，当hook的方法在主类中没实现而在父类有实现时，会导致无线循环，解决方案如下图所示
> !image-2018-07-06-17-06-47-091.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)