I have retried to reset the environment by `HOW-TO-BUILD.md` ， and the compile of “ Build from source using ’scripts/build_from_source.sh” looks fine to me . Also I suggest the config of the compile environment would be more clear and reachable . I also have checked the following issue which looks fine to me： * Git Tag matches the hash. * License and NOTICE is fine. * There are license headers in source files.
I change my vote to +1 。 Thanks ！ Adam Feng <[email protected]> 于2018年7月24日周二 下午2:51写道： > Hi, shihan > > Please check the environment in `HOW-TO-BUILD.md` and try again. > > Thanks. > Adam Feng > 在 2018年7月23日 +0800 PM4:12，shihan zheng <[email protected]>，写道： > > -1 > > - build from source using `scripts/build_from_source.sh` failed ! > > > > > > 申远 <[email protected]> 于2018年7月23日周一 上午11:12写道： > > > > > +1 binding. > > > > > > I checked the following issue which looks fine to me > > > > > > * Git Tag matches the hash. > > > * License and NOTICE is fine. > > > * Build from source using ’scripts/build_from_source.sh’ > > > * There are license headers in source files. > > > > > > > 在 2018年7月19日，21:02，Adam Feng <[email protected]> 写道： > > > > > > > > +1 binding. > > > > > > > > I checked: > > > > - Git tag and hash are correct > > > > - LICENSE file looks good > > > > - NOTICE is fine > > > > - Source files have license header s > > > > - No unexpected binaries (not sure for the gradle-wrapper.jar, I > > > suppose it is known and not of legal concern) > > > > - Key and signed information are OK > > > > - Can build from source using `scripts/build_from_source.sh` > > > > > > > > > > > > Thanks. > > > > Adam Feng > > > > 在 2018年7月19日 +0800 PM8:25，Hanks Zhang <[email protected]>，写道： > > > > > Hi Weex Community, > > > > > > > > > > I'm calling this vote to release Apache Weex (Incubating) version > > > 0.19.0. > > > > > > > > > > The tag to be voted upon: > > > > > > > > > > [ > > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-weex.git;a=shortlog;h=refs/tags/0.19.0-rc3](https://git-wip-us.apache.org/repos/asf?p=incubator-weex.git;a=shortlog;h=refs/tags/0.19.0-rc3) > > > > > > > > > > Hash for the release tag: > > > > > > > > > > ab1a91db5aa585d5e7721311260ad5dd3a0e4b16 > > > > > > > > > > The source tarball can be found at: > > > > > > > > > > [ > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/weex/0.19.0/RC3/](https://dist.apache.org/repos/dist/dev/incubator/weex/0.19.0/RC3/) > > > > > > > > > > The artifacts have been signed with Key: 4FD8BC09C7E9DB81, which > can be > > > > > found in the keys file: > > > > > > > > > > [ > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/weex/KEYS](https://dist.apache.org/repos/dist/dev/incubator/weex/KEYS) > > > > > > > > > > Release note about this version: > > > > > > > > > > [ > > > > > > > > > https://issues.apache.org/jira/projects/WEEX/issues/WEEX-464](https://issues.apache.org/jira/projects/WEEX/issues/WEEX-464) > > > > > > > > > > This vote will remain open for at least 72 hours. > > > > > > > > > > Please vote on releasing this RC. > > > > > > > > > > [ ] +1 approve > > > > > > > > > > [ ] +0 no opinion > > > > > > > > > > [ ] -1 disapprove (and the reason why) > > > > > > > > > > -- > > > > Best Regards! > > --------------------- > > Shihan Zheng (Weex project team member ) > -- Best Regards! --------------------- Shihan Zheng (Weex project team member )
