[
https://issues.apache.org/jira/browse/WEEX-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16580642#comment-16580642
]
ASF GitHub Bot commented on WEEX-541:
-------------------------------------
wqyfavor closed pull request #1380: [WEEX-541][iOS]Vertical Pan may not trigger
'start' event on some dev…
URL: https://github.com/apache/incubator-weex/pull/1380
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ios/sdk/WeexSDK/Sources/Events/WXComponent+Events.m
b/ios/sdk/WeexSDK/Sources/Events/WXComponent+Events.m
index 84dcdd1cb0..069b66b0d8 100644
--- a/ios/sdk/WeexSDK/Sources/Events/WXComponent+Events.m
+++ b/ios/sdk/WeexSDK/Sources/Events/WXComponent+Events.m
@@ -632,7 +632,7 @@ - (void)onPan:(UIPanGestureRecognizer *)gesture
[self fireEvent:@"horizontalpan" params:@{@"state":state,
@"changedTouches":resultTouch ? @[resultTouch] : @[]}];
}
- if (_listenVerticalPan && (gesture.state != UIGestureRecognizerStateBegan
|| fabs(translation.y) > fabs(translation.x))) {
+ if (_listenVerticalPan && (gesture.state != UIGestureRecognizerStateBegan
|| fabs(translation.y) >= fabs(translation.x))) {
[self fireEvent:@"verticalpan" params:@{@"state":state,
@"changedTouches":resultTouch ? @[resultTouch] : @[]}];
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Vertical Pan may not trigger 'start' event on some devices.
> -----------------------------------------------------------
>
> Key: WEEX-541
> URL: https://issues.apache.org/jira/browse/WEEX-541
> Project: Weex
> Issue Type: Bug
> Components: iOS
> Affects Versions: 0.19
> Reporter: Wang Qianyuan
> Assignee: XuYouyang
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
