[
https://issues.apache.org/jira/browse/WEEX-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581896#comment-16581896
]
ASF GitHub Bot commented on WEEX-566:
-------------------------------------
YorkShen commented on a change in pull request #1437: [WEEX-566][Android] add
jsb version file to make jsb.so can update
URL: https://github.com/apache/incubator-weex/pull/1437#discussion_r210468815
##########
File path:
android/sdk/src/main/java/com/taobao/weex/utils/WXSoInstallMgrSdk.java
##########
@@ -242,6 +268,22 @@ public static void copyStartUpSo() {
} else {
WXEnvironment.extractSo();
}
+
+ Closeable w = null;
+ try {
+ if(!versionFile.exists())
+ versionFile.createNewFile();
+ FileWriter fileWriter = new FileWriter(versionFile);
Review comment:
Move `fileWriter` out of the try clause and close the `fileWriter` in
finally would be better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> add jsb version file to make jsb can update
> -------------------------------------------
>
> Key: WEEX-566
> URL: https://issues.apache.org/jira/browse/WEEX-566
> Project: Weex
> Issue Type: Improvement
> Components: Android
> Affects Versions: 0.19
> Reporter: Yayun Dong
> Assignee: YorkShen
> Priority: Major
> Fix For: 0.18
>
>
> add jsb version file to make jsb can update
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
