[
https://issues.apache.org/jira/browse/WEEX-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591111#comment-16591111
]
ASF GitHub Bot commented on WEEX-590:
-------------------------------------
YorkShen closed pull request #1470: [WEEX-590][Android] add more info to report
URL: https://github.com/apache/incubator-weex/pull/1470
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
b/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
index db4d359635..b28676443d 100644
--- a/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
+++ b/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
@@ -2104,27 +2104,6 @@ private void doReportJSException(String instanceId,
String function, String exce
}
}
- private boolean checkEmptyScreen(WXSDKInstance instance){
- if (null == instance || instance.isDestroy()){
- return false;
- }
- WXComponent rootComponent = instance.getRootComponent();
- if (null == rootComponent) {
- return true;
- }
-
- View rootView = rootComponent.getRealView();
- if (null == rootView){
- return true;
- }
-
- if (rootView instanceof ViewGroup) {
- return ((ViewGroup) rootView).getChildCount() > 0;
- }else {
- return false;
- }
- }
-
private void registerDomModule() throws WXException {
/** Tell Javascript Framework what methods you have. This is Required.**/
Map<String, Object> domMap = new HashMap<>();
diff --git
a/android/sdk/src/main/java/com/taobao/weex/performance/WXInstanceExceptionRecord.java
b/android/sdk/src/main/java/com/taobao/weex/performance/WXInstanceExceptionRecord.java
index 3dd8b5ff9f..036aa286ba 100644
---
a/android/sdk/src/main/java/com/taobao/weex/performance/WXInstanceExceptionRecord.java
+++
b/android/sdk/src/main/java/com/taobao/weex/performance/WXInstanceExceptionRecord.java
@@ -21,6 +21,7 @@
import java.util.ArrayList;
import java.util.Collections;
import java.util.Comparator;
+import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Map.Entry;
@@ -145,12 +146,18 @@ public void checkEmptyScreenAndReport() {
break;
}
}
+ Map<String,String> flagMap = new HashMap<>(4);
+ flagMap.put("wxBeginRender",String.valueOf(mBeginRender));
+ flagMap.put("wxHasAddView",String.valueOf(hasAddView.get()));
+ flagMap.put("wxHasDegrade",String.valueOf(hasDegrade.get()));
+
flagMap.put("wxHasReportScreenEmpty",String.valueOf(mHasReportScreenEmpty));
+
WXExceptionUtils.commitCriticalExceptionRT(
instanceId,
hasJsException ? WXErrorCode.WX_RENDER_ERR_JS_RUNTIME :
WXErrorCode.WX_RENDER_ERR_NATIVE_RUNTIME,
"checkEmptyScreenAndReport",
convertExceptionListToString(),
- null
+ flagMap
);
}
diff --git
a/android/sdk/src/main/java/com/taobao/weex/utils/WXExceptionUtils.java
b/android/sdk/src/main/java/com/taobao/weex/utils/WXExceptionUtils.java
index 059911cf58..84cc7258f2 100644
--- a/android/sdk/src/main/java/com/taobao/weex/utils/WXExceptionUtils.java
+++ b/android/sdk/src/main/java/com/taobao/weex/utils/WXExceptionUtils.java
@@ -87,6 +87,7 @@ public static void commitCriticalExceptionRT(@Nullable final
String instanceId,
commitMap.put(WXInstanceExceptionRecord.KEY_EXP_STAGE_LIST,instance.getExceptionRecorder().convertStageToStr());
String bundleTemplate = instance.getTemplate();
commitMap.put("wxTemplateOfBundle",null ==
bundleTemplate ?"has recycle by gc":bundleTemplate);
+
commitMap.put("wxPageName",instance.getWXPerformance().pageName);
}
} else {//instance is null for instance id is null
if (!TextUtils.isEmpty(WXSDKInstance.requestUrl)) {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Android] add more exception report
> -----------------------------------
>
> Key: WEEX-590
> URL: https://issues.apache.org/jira/browse/WEEX-590
> Project: Weex
> Issue Type: Bug
> Components: Android
> Reporter: peihan
> Assignee: YorkShen
> Priority: Major
>
> - add more exception report
> - rm useless code
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
