cxfeng1 closed pull request #1487: [iOS] Fix on iOS9, text cannot be deleted
when exceeds maxLength.
URL: https://github.com/apache/incubator-weex/pull/1487
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ios/sdk/WeexSDK/Sources/Component/WXEditComponent.mm
b/ios/sdk/WeexSDK/Sources/Component/WXEditComponent.mm
index 495f32b62a..f702c617dd 100644
--- a/ios/sdk/WeexSDK/Sources/Component/WXEditComponent.mm
+++ b/ios/sdk/WeexSDK/Sources/Component/WXEditComponent.mm
@@ -598,6 +598,10 @@ - (BOOL)textField:(UITextField *)textField
shouldChangeCharactersInRange:(NSRang
NSUInteger rangeLength = range.length;
NSUInteger newLength = oldLength - rangeLength + replacementLength;
+ if (newLength <= oldLength) {
+ // deleting, we should allow delete
+ return YES;
+ }
return newLength <= [_maxLength integerValue] ;
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
