fishyumiao opened a new issue #1493: ios ModalUI显示相关问题 URL: https://github.com/apache/incubator-weex/issues/1493 ## Description 使用weex sdk 0.18.0发现 ‘modal.toast({ message: '123'})'显示不了 查看modalUIModule源码,发现model父view使用的不是keyWindow: UIView *superView = [[[UIApplication sharedApplication] windows] objectAtIndex:0]; 正好我的App有多个window,第一个window为hidden,故显示不了。 weex sdk更新到最新版本发现此处已经修改,并能正确显示’modal.toast‘窗口了。 UIView *superView = self.weexInstance.rootView.window; if (!superView) { superView = self.weexInstance.rootView; } 但是在 - (UIView *)toastViewForMessage:(NSString *)message superView:(UIView *)superView 中, 仍然又出现了:UIWindow *window = [[[UIApplication sharedApplication] windows] objectAtIndex:0]; 既然有superView了,就可以用superView了,这里应该去掉!!! 另: 又往下面看了几行,发现switch中,每个分支都有: point = CGPointMake(window.frame.size.width/2, window.frame.size.height/2); 这也太不走心了,明显应该提出去的代码写进switch。。。。。。 还有weex sdk中 ’WXModuleCallback‘既然已经标识为deprecated,推荐使用’WXModuleKeepAliveCallback‘,为什么还不将所有WXModuleCallback替换掉? 搞得一堆warnning~~~用起来不爽啊~~~ ## Environment ios weex sdk 0.18.0
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
