Hanks10100 commented on a change in pull request #1520: [jsfm] separate vue
framework and add vue-api
URL: https://github.com/apache/incubator-weex/pull/1520#discussion_r217254424
##########
File path: runtime/entries/vue.js
##########
@@ -17,7 +17,45 @@
* under the License.
*/
-import setup from './setup'
-import * as Vue from 'weex-vue-framework'
+const instanceOptions = {}
Review comment:
The `instanceOptions` variable will always exist even pages are destroyed,
it may cause a potential memory leak, we should figure out another way to
implement instance lifecycles.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
