[
https://issues.apache.org/jira/browse/WEEX-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649940#comment-16649940
]
ASF GitHub Bot commented on WEEX-643:
-------------------------------------
YorkShen closed pull request #1632: [WEEX-643][Android] fix image flash in
sticky item
URL: https://github.com/apache/incubator-weex/pull/1632
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/android/sdk/src/main/java/com/taobao/weex/ui/view/listview/adapter/ListBaseViewHolder.java
b/android/sdk/src/main/java/com/taobao/weex/ui/view/listview/adapter/ListBaseViewHolder.java
index 844cdc09d7..2419b6ec71 100644
---
a/android/sdk/src/main/java/com/taobao/weex/ui/view/listview/adapter/ListBaseViewHolder.java
+++
b/android/sdk/src/main/java/com/taobao/weex/ui/view/listview/adapter/ListBaseViewHolder.java
@@ -34,13 +34,17 @@
*/
public class ListBaseViewHolder extends RecyclerView.ViewHolder {
private int mViewType;
- private boolean isRecycled = true;
+ private boolean isRecycled;
private WeakReference<WXComponent> mComponent;
public ListBaseViewHolder(WXComponent component, int viewType) {
super(component.getHostView());
mViewType = viewType;
mComponent = new WeakReference(component);
+ // This tag is used to determine whether bind / rebind data is needed.
+ // It should be false When component can not be recycled Which means
+ // no need to bind / rebind data.
+ isRecycled = component.canRecycled();
}
public ListBaseViewHolder(View view, int viewType) {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Android] fix image flash in sticky item
> ----------------------------------------
>
> Key: WEEX-643
> URL: https://issues.apache.org/jira/browse/WEEX-643
> Project: Weex
> Issue Type: Bug
> Reporter: yxp
> Assignee: Adam Feng
> Priority: Major
>
> When slide up and down in recyclerview, the image, in the sticky item,
> sometimes flash which is not a better feeling.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
