[ 
https://issues.apache.org/jira/browse/WEEX-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700286#comment-16700286
 ] 

ASF GitHub Bot commented on WEEX-538:
-------------------------------------

Darin726 closed pull request #1372: [WEEX-538][Android] do not shutdown 
websocket when debug
URL: https://github.com/apache/incubator-weex/pull/1372
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java 
b/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
index c0bf2c5596..768b854287 100644
--- a/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
+++ b/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
@@ -273,9 +273,9 @@ private void initWXBridge(boolean remoteDebug) {
       WXEnvironment.sDebugServerConnectable = true;
     }
 
-    if (mWxDebugProxy != null) {
-      mWxDebugProxy.stop(false);
-    }
+//    if (mWxDebugProxy != null) {
+//      mWxDebugProxy.stop(false);
+//    }
     if (WXEnvironment.sDebugServerConnectable && 
(WXEnvironment.isApkDebugable() || WXEnvironment.sForceEnableDevTool)) {
       if (WXEnvironment.getApplication() != null) {
         try {


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> do not shutdown debug websocket
> -------------------------------
>
>                 Key: WEEX-538
>                 URL: https://issues.apache.org/jira/browse/WEEX-538
>             Project: Weex
>          Issue Type: Improvement
>          Components: Android
>    Affects Versions: 0.18
>            Reporter: Yayun Dong
>            Assignee: codefurture
>            Priority: Minor
>             Fix For: 0.18
>
>
> do not shutdown debug websocket



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to