[
https://issues.apache.org/jira/browse/WEEX-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16708447#comment-16708447
]
ASF GitHub Bot commented on WEEX-673:
-------------------------------------
weex-bot commented on issue #1860: [WEEX-673][weex_core][iOS][Android] fix
crash && advance RTL performance
URL: https://github.com/apache/incubator-weex/pull/1860#issuecomment-444026835
<!--
2 failure: Code file ios/sdk..., Code file weex_co...
5 warning: No Changelog chan..., Potential BREAK C..., Potential BREAK
C..., Potential BREAK C..., Potential BREAK C...
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Fails</th>
</tr>
</thead>
<tbody><tr>
<td>:no_entry_sign:</td>
<td>Code file ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm does not
have the copyright header.</td>
</tr>
<tr>
<td>:no_entry_sign:</td>
<td>Code file
weex_core/Source/android/jniprebuild/jniheader/WXBridge_jni.h does not have the
copyright header.</td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
<tr>
<td>:warning:</td>
<td>Potential BREAK CHANGE. Modify public in
android/sdk/src/main/java/com/taobao/weex/bridge/WXBridge.java without metion
it in commit message. You'd better add '@notdanger' in your commit log. </td>
</tr>
<tr>
<td>:warning:</td>
<td>Potential BREAK CHANGE. Modify public in
android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java without
metion it in commit message. You'd better add '@notdanger' in your commit log.
</td>
</tr>
<tr>
<td>:warning:</td>
<td>Potential BREAK CHANGE. Modify public in
android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java without
metion it in commit message. You'd better add '@notdanger' in your commit log.
</td>
</tr>
<tr>
<td>:warning:</td>
<td>Potential BREAK CHANGE. Modify public in
android/sdk/src/main/java/com/taobao/weex/ui/action/GraphicActionLayout.java
without metion it in commit message. You'd better add '@notdanger' in your
commit log. </td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>danger test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a
href="http://github.com/danger/danger-js/";>dangerJS</a>
</p>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [weex_core][iOS][Android] fix crash && advance RTL performance
> ---------------------------------------------------------------
>
> Key: WEEX-673
> URL: https://issues.apache.org/jira/browse/WEEX-673
> Project: Weex
> Issue Type: Bug
> Components: Android, iOS
> Affects Versions: 0.20
> Reporter: KAI TIAN
> Assignee: YorkShen
> Priority: Blocker
> Fix For: 0.20
>
>
> To fix android crash when call isNativeLayoutDirectionRTL by JNI, now we
> don't read layoutDirection manually again，only receive param which transfered
> by C++ -> Java.
> As we all know JNI is very slow, now we avoid call JNI method when layout, it
> can speedup weex render.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
