-1 I checked: - License is good - Notice is ok - Signature & hashes is ok - Android build failed, it depends on a local.properties ndk.dir settings which cannot been passed from command line arguments as per instruction. build.gradle needs to be fixed.
> 在 2019年5月5日，下午1:53，Adam Feng <[email protected]> 写道： > > +1 binding > > I checked: > - LICENCE is good > - NOTICE is ok > - signature and hashes good > > shihan zheng <[email protected]> 于 2019年5月5日周日 上午10:29写道： > >> +1 binding >> >> I checked: >> - LICENCE is good >> - NOTICE is ok >> - signature and hashes good >> - build the code from source is fine >> >> Willem Jiang <[email protected]> 于2019年5月2日周四 下午3:59写道： >> >>> There is a big holiday in China, I guess lot lof PPMC member may out of >>> town. >>> @York Shen I think you need to ping around PPMC once you send out the >>> release mail next time. >>> Now we have to wait for the feedback from PPMC. >>> >>> Willem Jiang >>> >>> Twitter: willemjiang >>> Weibo: 姜宁willem >>> >>> On Thu, May 2, 2019 at 2:26 PM Myrle Krantz <[email protected]> wrote: >>>> >>>> Hey Weex PMC, >>>> >>>> I'm concerned by the lack of voting here. Creating a release candidate >>> as >>>> YorkShen has done here requires a fair bit of effort. >>>> >>>> Please check the release and vote on it. >>>> >>>> YorkShen, you don't have to close the vote after 72 hours. 72 is a >>>> minimum, not a maximum. You can wait until people have voted. Perhaps >>>> there is a holiday there that prevented people from getting to this in >>> the >>>> 72 hours? >>>> >>>> Best, >>>> Myrle >>>> Mentor, Apache Weex (Incubating) >>>> >>>> On Mon, Apr 29, 2019 at 10:43 AM 申远 <[email protected]> wrote: >>>> >>>>> Hi, community. >>>>> >>>>> I am going to call a vote for release Apache Weex (Incubating) 0.24.0 >>> as >>>>> mentioned before. >>>>> >>>>> >>>>> - Git tag for this Release: >>>>> https://github.com/apache/incubator-weex/releases/tag/0.24.0-RC1 >>>>> - The source tarball could be found at : >>>>> >>>>> >>> >> https://dist.apache.org/repos/dist/dev/incubator/weex/0.24.0/RC1/apache-weex-incubating-0.24.0-RC1-src.tar.gz >>>>> - The signature of the source tarball could be found at : >>>>> >>>>> >>> >> https://dist.apache.org/repos/dist/dev/incubator/weex/0.24.0/RC1/apache-weex-incubating-0.24.0-RC1-src.tar.gz.asc >>>>> - The SHA-512 checksum of the source tarball could be found at : >>>>> >>>>> >>> >> https://dist.apache.org/repos/dist/dev/incubator/weex/0.24.0/RC1/apache-weex-incubating-0.24.0-RC1-src.tar.gz.sha512 >>>>> - The source tarball is signed with Key: EC0B28566883F364, which >>> could >>>>> be found in the key file: >>>>> https://dist.apache.org/repos/dist/release/incubator/weex/KEYS >>>>> >>>>> One can build the binary from source according to >>>>> >>> https://github.com/apache/incubator-weex/blob/0.24.0-RC1/HOW-TO-BUILD.md >>>>> with >>>>> corresponding compiling tools. >>>>> >>>>> Note:* As the compiling tools relies on XCode/NDK 13/NDK 16, it would >>> not >>>>> be a surprise if your build fails on a non-Mac environment or without >>>>> corresponding NDK tools.* >>>>> >>>>> This vote will remain open for at least 72 hours. Please vote on >>> releasing >>>>> this RC. >>>>> >>>>> [ ] +1 approve >>>>> [ ] +0 no opinion >>>>> [ ] -1 disapprove (and reason why) >>>>> >>>>> Best Regards, >>>>> YorkShen >>>>> >>>>> 申远 >>>>> >>> >> >> >> -- >> >> Best Regards! >> --------------------- >> Shihan Zheng (Weex project team member ) >>
