+1 I checked: - License is good - Notice is ok - Signature & hashes is ok - Build passed.
> 在 2019年5月7日，下午7:58，Adam Feng <[email protected]> 写道： > > Change my vote to +1, I have seen the files at the end of LICENSE… > > Thanks. > Adam Feng > 在 2019年5月7日 +0800 PM7:54，Adam Feng <[email protected]>，写道： >> -1 >> >> According to apache release policy[1]： >> >>> When a package bundles code under several licenses, the LICENSE file MUST >>> contain details of all these licenses. For each component which is not >>> Apache licensed, details of the component MUST be appended to the LICENSE >>> file. >>> >> There a lot of files in [2] are not Apache licensed, for example [3]， and I >> could not find them in the LICENSE file. >> >> >> [1] http://www.apache.org/legal/release-policy.html#license-file >> [2] weex_core/Source/android/jsengine/dependence/ >> [3] >> weex_core/Source/android/jsengine/dependence/bmalloc/bmalloc/FixedVector.h >> >> Thanks. >> Adam Feng >> 在 2019年5月7日 +0800 PM7:39，申远 <[email protected]>，写道： >>> Hi, community. >>> >>> I am going to call a vote for release Apache Weex (Incubating) 0.24.0-RC3 >>> which fixed the following problems in RC2 and RC21: >>> >>> - JS build failure due to missing files. >>> - Android building failure due to environment or compiling tool version. >>> - Incomplete source file headers >>> - Revert modifying third-party file header, namely files under >>> weex_core/Source/android/jsengine/dependence directory. >>> >>> The content of 0.24.0-RC3 is listed below: >>> >>> - Git tag for this Release: >>> https://github.com/apache/incubator-weex/tree/0.24.0-RC3 >>> - The source tarball could be found at : >>> *https://dist.apache.org/repos/dist/dev/incubator/weex/0.24.0/RC3/apache-weex-incubating-0.24.0-RC3-src.tar.gz >>> <https://dist.apache.org/repos/dist/dev/incubator/weex/0.24.0/RC3/apache-weex-incubating-0.24.0-RC3-src.tar.gz>* >>> - The signature of the source tarball could be found at : >>> *https://dist.apache.org/repos/dist/dev/incubator/weex/0.24.0/RC3/apache-weex-incubating-0.24.0-RC3-src.tar.gz.asc >>> <https://dist.apache.org/repos/dist/dev/incubator/weex/0.24.0/RC3/apache-weex-incubating-0.24.0-RC3-src.tar.gz.asc>* >>> - The SHA-512 checksum of the source tarball could be found at : >>> *https://dist.apache.org/repos/dist/dev/incubator/weex/0.24.0/RC3/apache-weex-incubating-0.24.0-RC3-src.tar.gz.sha512 >>> <https://dist.apache.org/repos/dist/dev/incubator/weex/0.24.0/RC3/apache-weex-incubating-0.24.0-RC3-src.tar.gz.sha512>* >>> - The source tarball is signed with Key: EC0B28566883F364, which could >>> be found in the key file: >>> https://dist.apache.org/repos/dist/release/incubator/weex/KEYS >>> >>> One can build the binary from source according to >>> https://github.com/apache/incubator-weex/blob/0.24.0-RC3/HOW-TO-BUILD.md#build-all-by-script >>> with >>> corresponding compiling tools. >>> >>> Still:* The compiling tools relies on XCode/NPM/Android SDK/Android NDK >>> 13/Android NDK 16, it would not be a surprise if your build fails on a >>> non-Mac environment or without corresponding tools.* >>> >>> *Though I have tested the building process in my computer, one may still >>> meet compiling problems as you would compile JS/Android/iOS/C++ together.* >>> >>> This vote will remain open for at least 72 hours. Please vote on releasing >>> this RC. >>> >>> [ ] +1 approve >>> [ ] +0 no opinion >>> [ ] -1 disapprove (and reason why) >>> >>> Best Regards, >>> YorkShen >>> >>> 申远
