Thanks For your reply,
As you said, playground should be added as a submodule of weex_sdk repo. in iOS, we can also change snapshot version of weex_sdk by update playground's Podfile to the relative branch, and I will write a README like Android project. | | 王仁敏 | | [email protected] | 签名由网易邮箱大师定制 On 07/9/2019 20:50，York Shen<[email protected]> wrote： Thanks for both of you. But I have following concerns for your iOS plan: In weex_sdk repo, playground will be added as a Git submodule. It looks like you are reversing the dependency between weex_sdk and playground. I am afraid this will cause developers confusion. In weex playground repo, Android Weex Playground relies on a snapshot version of weex_sdk. This SNAPSHOT version shall only be shared among core-contributor of weex. I am not sure whether this can be achieved through CocoaPods Correct me if I am wrong as I am not an iOS developer. Best Regards, York Shen 申远 在 2019年7月9日，20:35，王仁敏 <[email protected]> 写道： That's a great idea! It's a good solution to separate weex_sdk and playground into two repos by using Git Submodule. In iOS, instead of using git submodule directly, this can be achieved by change the CocoaPods dependence, which we use in weex_sdk project now, from relative path to git-link. If we seperate them to two repos, we can solved our problm only by modifing the Podfile as below: pod 'WeexSDK', :git => 'https://github.com/apache/incubator-weex.git’ Besides, we can the specific branch, tag or even a commit in the git-link. Reference Link: https://guides.cocoapods.org/using/the-podfile.html Best Regards, Renmin Wang | | 王仁敏 | | [email protected] | 签名由网易邮箱大师定制 On 07/9/2019 15:15，York Shen<[email protected]> wrote： Sounds like a good plan, but there are some issues you need to be careful with: Write a document about how to configure the submodule for weex_sdk and update playground version when a new weex_sdk is released, maybe a README is enough I am not sure about SNAPSHOT version, will this be conflicted with ASF’s policy? Or is it ok if we don’t provide the SNAPSHOT of weex_sdk beyond our core-developers? Best Regards, York Shen 申远 在 2019年7月9日，15:04，Huiying Jiang <[email protected]> 写道： Hi there, I am trying to separate weex_sdk and playground into two repos.After moving the playground to a new repository, here comes a question about dealing with the repos’ relationship.And I am considering adding ‘weex_playground’ into ‘incubator-weex’ as a submodule.Here are some details: 1.The playground submodule will be cloned and updated automatically when developers clone the ‘incubator-weex’ repo and build it.In this case, playground project will implement the source code of weex-sdk. 2.When developer directly clone the 'weex-playground' repo and run it separately, the playground project will implement a corresponding aar version of weex-sdk. That means some weex-sdk snapshots will be needed to support playground since some commits of playground may rely on unreleased features of weex-sdk. Does this solution sounds reasonable? Regards, Katherine On 2019/07/04 07:35:53, Huiying Jiang <[email protected]> wrote: Hi,> I would like to do the separating of android.> Regards,> Katherine.> On 2019/07/04 07:20:37, 申远 <[email protected]> wrote: > As discussed before [1], Weex repo should be separated into two repos:> > - weex_sdk> > - weex playground> > I have just create a new repo for Weex Playground[2].> > As I am a little overloaded these days, it's really helpful if someone in> > this mailing list could help me do the separating.> > [1]> > https://lists.apache.org/thread.html/6a08422bc28743e132ae23e002bf5713eb464447a9ef35236dd1b957@%3Cdev.weex.apache.org%3E> > [2] https://github.com/apache/incubator-weex-playground> > Best Regards,> > YorkShen> > 申远> >
