On Thu, Jul 16, 2015 at 4:37 PM, Craig L Russell <[email protected]> wrote: > >> On Jul 15, 2015, at 10:22 PM, Sam Ruby <[email protected]> wrote: >> >> On Wed, Jul 15, 2015 at 9:07 PM, Craig L Russell >> <[email protected]> wrote: >>> Hi, >>> >>> When opening item 7A, I get an error message TypeError: Cannot call method >>> 'replace' of undefined >>> >>> The draft minutes show this item as tabled. >> >> Fixed. Thanks! >> >>> After voting on item 7B, the mismatch in Joe Witt’s name caused the tool to >>> disregard the successful vote. >> >> I can't reproduce this. I also see that this item is marked as >> unanimous both in the tool and in the committed minutes. > > You can see the edits I had to make in the commit right after the board > meeting.
What I see in the initial commit of the minutes (r60172): + Special Order 7B, Establish the Apache NiFi Project, was + approved by Unanimous Vote of the directors present. + This looks right to me. >>> I tried to fix these issues when saving draft minutes, but the draft >>> minutes cannot be edited in the tool. >> >> You should be able to edit individual agenda item minutes (including >> votes) > > Yes, and I tried to edit the items and got the error above on 7A. > >> by going to that agenda item and clicking "edit minutes" (or >> "vote") and then changing the value in the text area. > > I guess we need a good set of test cases. What made 7A unique was the non-standard agenda title (it wasn't a clone of an establish, change, or terminate). I've got a fair number of test cases for situations that I have foreseen; what isn't well covered by the tests is circumstances that I haven't foreseen. I also don't have a large number of test cases for keyboard navigation, which is due to the difficultly of correctly simulating this. >> When committing draft minutes, you are also presented with the full >> text in a textarea that you can change before committing. I spotted a >> problem where some keys were intercepted and used for navigation - >> I've now fixed this. > > I couldn’t use the letters a or r which made “approved by unanimous consent” > a non-starter. ;-) Fixed. I'm still not sure why that menu is different, but I added code to handle it. > So is the navigation enabled for <ctrl-letter> instead? I’ve never tried that. No. In fact, I try not to mess with the "meta" keys as they are important to Mac users :-) > Don’t worry about this on vacation! Too late! > Craig - Sam Ruby >>> Craig >>> >>> Craig L Russell >>> Architect, Oracle >>> http://db.apache.org/jdo >>> 408 276-5638 mailto:[email protected] >>> P.S. A good JDO? O, Gasp! >> >> - Sam Ruby > > Craig L Russell > Architect, Oracle > http://db.apache.org/jdo > 408 276-5638 mailto:[email protected] > P.S. A good JDO? O, Gasp! >
