On Mon, Aug 31, 2015 at 12:46 PM, Craig L Russell <[email protected]> wrote: > >> On Aug 31, 2015, at 9:06 AM, Sam Ruby <[email protected]> wrote: >> >> On Mon, Aug 31, 2015 at 11:08 AM, Craig L Russell >> <[email protected]> wrote: >>> >>>> On Aug 31, 2015, at 8:06 AM, Sam Ruby <[email protected]> wrote: >>>> >>>> On Mon, Aug 31, 2015 at 10:54 AM, Craig L Russell <[email protected]> wrote: >>>>> So, now that I’ve added the folks from Virtual to iclas.txt, tooling has >>>>> detected a problem. >>>>> >>>>> icla.txt issues >>>>> >>>>> issue name >>>>> nocla Michelle Ball >>>>> nocla Lynsey Chaplik >>>>> nocla Graham Morris >>>>> nocla Tom Pappas >>>>> nocla Melissa Warnkin >>>>> nocla Christina Zagami >>>>> >>>>> We should be able to validate that these entries are ok. >>>> >>>> What, if any, validation should be done on this field? >>> >>> Should be one of: >>> >>> Signed CLA; stub file/dir name >>> President; anything >>> Treasurer; anything >> >> Fixed, though I partially chickened out. >> >> Previous check was that the final field contained the string 'CLA'. >> >> Current check is that the final field contains the string 'CLA' or >> starts with 'President;' or starts with 'Treasurer;'. >> >> There are a number of entries that don't have a stub file/dir name; a >> number of these contain other comments. Let me know if you want me to >> tighten up this check further. > > I am curious, and hope I don’t have to go through iclas.txt looking for > “other comments”. Can you list them here? I’d like to fix them but don’t know > whether they deserve to be flagged in the tool.
Sure. Values that don't fit the pattern mentioned above: Signed CLA;andrea-vacondio.com-icla Signed CLA;arthur-ryman,arthur-ryman-2 Signed CLA;barrett-jay-reed,barrett-j-reed Signed CLA (Batik);henri-ruini Signed CLA (Batik);max-froumentin Signed CLA (Batik);patrick-schmitz Signed CLA;charles-wiecha (page 3 missing) Signed CLA; ** is this the same as below ? ** Signed CLA;jim-ma (+=r9120) Signed CLA;jonathan-locke,jonathan-locke-2 Signed CLA;kyle-marvin,kyle-marvin-2 Signed CLA;matthew-duftler,matthew-duftler-2 Signed CLA;maxime-ritter,maxime-ritter-2 Signed CLA;maxim-khutornenko Signed CLA;michael-yoder,michael-yoder-2 Signed CLA;myrna-lunteren,myrna-van-lunteren Signed CLA (name shown as Poltio);david-poltio Signed CLA (Neowebscript) Signed CLA;nicolas-toper,nicolas-toper-2 Signed CLA;nitay-joffe-1,nitay-joffe-2 Signed CLA;noah-levitt,noah-levitt-2 Signed CLA/nv;ajith-ranabahu Signed CLA/nv;dasarath-weeratunge Signed CLA/nv;robert-leland Signed CLA;** only CCLA found ** Signed CLA (OpenORB);jesper-pederson Signed CLA (OpenORB);shawn-k-boyce Signed CLA;paul-evenblij,paul-evenblij-2 Signed CLA (+=r9120) Signed CLA (+=r9120; originally Quellhurst;updated in r9147) Signed CLA (+=r9154) Signed CLA (+=r9154);michael-mccandless Signed CLA (+=r9154);ole-ersoy Signed CLA;robert-davies-2,robert-davies Signed CLA;rory-winston,rory-winston-2 Signed CLA (Spam Assassin);matthew-edward-kettler Signed CLA;tamara-boehm Signed CLA;vijay-venkataswamy-parthasarathy Signed CLA;werner-dittmann,werner-dittmann-2 Signed CLA;willem-jiang,willem-jiang-2 Signed CLA;william-smith,thad-smith Notes: 1) some (like the one containing +r9120), are present multiple times. 2) some that match the pattern (like maxim-khutornenko) are included because no matching stub or dir name was found - Sam Ruby
