On 13 March 2016 at 14:16, sebb <seb...@gmail.com> wrote: > On 13 March 2016 at 14:09, Sam Ruby <ru...@intertwingly.net> wrote: >> On Sun, Mar 13, 2016 at 9:52 AM, Sebastian Bazley <s...@apache.org> wrote: >>> >>> - if person.asf_member? >>> + if person.asf_member? # TODO is this the correct check? it includes >>> people in members unix group >>> member[:info] = person.members_txt >> >> In this particular case, I think so. It will only include information >> from members.txt in the view if you have read access to members.txt. > > Yes, but not everyone in the members unix group is an actual ASF > member with info in members.txt. > e.g. pono and other contractors > > Have a look at > > https://whimsy.apache.org/roster/committer/pono
More to the point, the member_nomination details are only set up if the person is not a person.asf_member. I.e. had pono been nominated, the code would assume he was already a member and not show the info. I wonder whether ASF::Person::asf_member?() should include Unix members at all. Or perhaps there need to be two methods: asf_isMember? asf_hasMemberKarma? >> - Sam Ruby
