On 14 March 2016 at 02:00, Sam Ruby <ru...@intertwingly.net> wrote:
> On Sun, Mar 13, 2016 at 9:43 PM, sebb <seb...@gmail.com> wrote:
>> The collate_minutes job is failing with:
>>
>> collate_minutes.rb:61:in `<main>': uninitialized constant ASF::Podling
>> (NameError)
>>
>> *** Exception NameError : collate_minutes.rb:61:in `<main>'
>> uninitialized constant ASF::Podling ***
>>
>> I don't get that problem when running it in a command shell.
>
> Like me, you probably have RUBYLIB set.  :-(

Yes, I did.
I'm dropping it now, because it masks problems ... I can always add it
back temporarily for testing.

> I broke this with
> https://github.com/apache/whimsy/commit/6f93a5273fec0706433531a9406ca040cfc0e77d
>
>> The podlings code was added relatively recently; perhaps the
>> environment which runs the script has not been updated with the latest
>> whimsy gem?
>
> Correct.  But I would rather fix the code so that it doesn't depend on the 
> gem:
>
> https://github.com/apache/whimsy/commit/f3ae7af285be0d4aa54319c01e8e9ced2fa077d0
>
> That code is the functional equivalent of setting the RUBYLIB
> environment variable.
>
>> Would it help to use bundler in the script?
>
> That would also work.

I tried that later, and that worked when I updated the Gemfile.

>> And/or I notice that some Gemfiles check for asf.version and if so use
>> a local whimsy-asf
>> Maybe they all should? The tools/Gemfile does not use a local whimsy AFAICT.
>
> I'd like to continue to phase out the gem.  At this point, they all
> should use a local version.  Unconditionally.

Sounds good; easy to test.

I'll make a start on that.

> - Sam Ruby

Reply via email to