> On Aug 20, 2016, at 5:58 PM, Sam Ruby <[email protected]> wrote: > > This part is problematic: > > nda: %w( nname nemail nid ), > + incomplete: %w( nname nemail ), > + unsigned: %w( nname nemail ),
I’ve changed this to use iname for incomplete and uname for unsigned. > > There is a form, consisting of a number of tables, where at any point > in time only one is visible. Each table has a number of input > elements. > > The problem is that, even if not visible at the moment, *all* of the > names and values for the input elements are sent to the server. For > this reason, all elements must be named uniquely. I'm highlighting > the problem here, but any changes made to these lines will affect the > other changes that you made. > > This part puzzles me: there is no use of React.js in the workbench: I’m not sure what happened here, but I’ve removed the js.rb files. I’ll make a branch and push it to git. Thanks, Craig > > incomplete.js.rb > new file mode 100644 > index 0000000..609de64 > --- /dev/null > +++ b/www/secretary/workbench/incomplete.js.rb > @@ -0,0 +1,5 @@ > +class INCOMPLETE < React > + def render > + _p 'INCOMPLETE' > + end > +end > diff --git a/www/secretary/workbench/unsigned.js.rb > b/www/secretary/workbench/unsigned.js.rb > new file mode 100644 > index 0000000..e0e3915 > --- /dev/null > +++ b/www/secretary/workbench/unsigned.js.rb > @@ -0,0 +1,5 @@ > +class UNSIGNED < React > + def render > + _p 'UNSIGNED' > + end > +end > > - Sam Ruby > > P.S. This would be easier to review if pushed to the server, perhaps > in a separate branch? > > > On Sat, Aug 20, 2016 at 8:46 PM, Craig Russell <[email protected]> > wrote: >> I’ve updated the patch. >> >> The actions for unsigned and incomplete create menu items ok except I’d like >> to have >> icla grant ccla nda mem other on one line and then >> incomplete unsigned on the next line >> >> >> >> >>> On Aug 20, 2016, at 9:01 AM, Craig Russell <[email protected]> wrote: >>> >>> Please review this patch. The intent is to promote unsigned and incomplete >>> to “first class” actions. >>> >>> 1. Allow secretary to fill the form for name, email address, pmc, and >>> podling. >>> 2. File action will move the document to deadletter/incomplete >>> 3. Commit action will commit the move and send email to the submitter, the >>> pmc, and the podling with a standard message. >>> >>> I’ve updated the application files that I can find. Now I need to find the >>> other places and figure out how to test this thing locally. (Thanks Sam for >>> your help so far). >>> >>> Thanks, >>> >>> Craig >>> >>> <unsigned.txt> >>> Craig L Russell >>> [email protected] >>> >>> >> >> Craig L Russell >> Architect >> [email protected] >> P.S. A good JDO? O, Gasp! >> >> >> >> >> >> Craig L Russell Architect [email protected] P.S. A good JDO? O, Gasp!
