On Sun, Aug 21, 2016 at 10:53 PM, Craig Russell <[email protected]> wrote: > What still does not work is pre-populating the iname and iemail (uname and > uemail) from the received document when selecting incomplete and unsigned. > Just like icla, ccla, and grant do now.
The place to look is here: https://github.com/apache/whimsy/blob/84b03760b311926c7f774a35dc85aaae8b87cc15/www/secretary/workbench/worklist.js#L112 > Then I want to see the email template for incomplete and unsigned filled from > the form. Fair to assume that this should appear on the right pane? If so, that code would go here: https://github.com/apache/whimsy/blob/d186820f9d2e61ae81bd406b2fae8feca17c4d69/www/secretary/workbench/file.cgi#L783 I'll note that you are starting to hit the reason why I am not overly enthusiastic about adding new features to this code base. So many different places need to be changed in order to add one (even relatively simple) new feature. And the coupling between those changes is high. By contrast, newer codebases (like board agenda) changes tend to be localized and variables are local not global. > And of course svn mv documents/received/icla.pdf unsigned <== needs to be a > complete path here. Add "Dir.chdir(RECEIVED) do"..."end" around the _.move @source, dest, and either change 'dest = "unsigned"' to `dest = DESTINATION['unsigned']` (to make use of your changes to DESTINATION) or `dest = ''deadletter/unsigned'`. > Craig - Sam Ruby >> On Aug 21, 2016, at 4:31 PM, [email protected] wrote: >> >> This is an automated email from the ASF dual-hosted git repository. >> >> clr pushed a commit to branch incomplete-unsigned >> in repository https://git-dual.apache.org/repos/asf/whimsy.git >> >> The following commit(s) were added to refs/heads/incomplete-unsigned by this >> push: >> new d186820 Change names for incomplete and unsigned >> d186820 is described below >> >> commit d186820f9d2e61ae81bd406b2fae8feca17c4d69 >> Author: Craig L Russell <[email protected]> >> AuthorDate: Sun Aug 21 16:31:33 2016 -0700 >> >> Change names for incomplete and unsigned >> --- >> www/secretary/workbench/file.cgi | 5 ++--- >> www/secretary/workbench/worklist.cgi | 24 ++++++++++++------------ >> 2 files changed, 14 insertions(+), 15 deletions(-) >> >> diff --git a/www/secretary/workbench/file.cgi >> b/www/secretary/workbench/file.cgi >> index cf70e1f..d27e8d6 100755 >> --- a/www/secretary/workbench/file.cgi >> +++ b/www/secretary/workbench/file.cgi >> @@ -611,11 +611,10 @@ _html do >> update_pending params, dest >> >> when 'incomplete' >> - _.system "whoami" >> @realname ||= @iname >> dest = "incomplete" >> >> - _h1 "Incomplete from #{@iname}" >> + _h1 "Incomplete document received from #{@iname}" >> _.move @source, dest >> >> update_pending params, dest >> @@ -624,7 +623,7 @@ _html do >> @realname ||= @nname >> dest = "unsigned" >> >> - _h1 "Unsigned from #{@uname}" >> + _h1 "Unsigned document received from #{@uname}" >> _.move @source, dest >> >> update_pending params, dest >> diff --git a/www/secretary/workbench/worklist.cgi >> b/www/secretary/workbench/worklist.cgi >> index 7e01e81..f911239 100755 >> --- a/www/secretary/workbench/worklist.cgi >> +++ b/www/secretary/workbench/worklist.cgi >> @@ -76,9 +76,9 @@ _html do >> elsif pending['doctype'] == 'nda' >> message = "NDA for #{pending['realname']}" >> elsif pending['doctype'] == 'incomplete' >> - message = "Incomplete for #{pending['nname']}" >> + message = "Incomplete document received from >> #{pending['iname']}" >> elsif pending['doctype'] == 'unsigned' >> - message = "Unsigned for #{pending['nname']}" >> + message = "Unsigned document received from #{pending['uname']}" >> end >> end >> end >> @@ -215,17 +215,17 @@ _html do >> _table do >> _tr do >> _td do >> - _label 'Name', for: 'nname' >> + _label 'Name', for: 'iname' >> end >> _td do >> - _input type: :text, name: 'nname', id: 'nname' >> + _input type: :text, name: 'iname', id: 'iname' >> end >> end >> >> _tr do >> _td.label 'EMail' >> _td.input do >> - _input name: 'nemail', id: 'nemail', type: 'email' >> + _input name: 'iemail', id: 'iemail', type: 'email' >> end >> end >> end >> @@ -235,17 +235,17 @@ _html do >> _table do >> _tr do >> _td do >> - _label 'Name', for: 'nname' >> + _label 'Name', for: 'uname' >> end >> _td do >> - _input type: :text, name: 'nname', id: 'nname' >> + _input type: :text, name: 'uname', id: 'uname' >> end >> end >> >> _tr do >> _td.label 'EMail' >> _td.input do >> - _input name: 'nemail', id: 'nemail', type: 'email' >> + _input name: 'uemail', id: 'uemail', type: 'email' >> end >> end >> >> @@ -503,13 +503,13 @@ _html do >> _tr do >> _td.label 'PMC' >> _td.input do >> - _input name: 'cpmc', id: 'cpmc', type: 'text' >> + _input name: 'ipmc', id: 'ipmc', type: 'text' >> end >> end >> _tr do >> _td.label 'Podling' >> _td.input do >> - _input name: 'cpodling', id: 'cpodling', type: 'text' >> + _input name: 'ipodling', id: 'ipodling', type: 'text' >> end >> end >> end >> @@ -517,13 +517,13 @@ _html do >> _tr do >> _td.label 'PMC' >> _td.input do >> - _input name: 'cpmc', id: 'cpmc', type: 'text' >> + _input name: 'upmc', id: 'upmc', type: 'text' >> end >> end >> _tr do >> _td.label 'Podling' >> _td.input do >> - _input name: 'cpodling', id: 'cpodling', type: 'text' >> + _input name: 'upodling', id: 'upodling', type: 'text' >> end >> end >> end >> >> -- >> To stop receiving notification emails like this one, please contact >> ['"[email protected]" <[email protected]>']. > > Craig L Russell > Architect > [email protected] > P.S. A good JDO? O, Gasp! > > > > >
