As luck would have it, rewriting how emails are constructed was going to be next on my list. If you look at icla.json.rb, the svn tasks are fairly clean and the mail tasks are a bit brute force, and contain a lot of common code. This code would be required for each of the actions, so I plan to factor it out into a common method.
I'll look at it later this afternoon. Part of that commit will be support for the various reject actions (incomplete, unsigned, etc), which will become trivial (jump immediately to the tasklist with no form, the task consists of a single email which you can browse before proceeding). - Sam Ruby On Thu, Sep 15, 2016 at 2:56 PM, Craig Russell <[email protected]> wrote: > Here’s a patch that doesn’t work: > > I tried to find any documentation on the Message class but failed to find > which property has the original “from” address. > > So do I need to convert the message:from into an array? I tried > > + cc += [message.from] <== line 120 > > but no luck > > Any ideas? > > Craig > > > --- a/www/secmail/views/actions/icla.json.rb > +++ b/www/secmail/views/actions/icla.json.rb > @@ -117,6 +117,7 @@ task "email #@email" do > # adjust copy lists > cc = mail.cc # from the template > cc += message.cc if message.cc # from the email message > + cc += message.from <== line 120 > cc << "private@#{pmc.mail_list}.apache.org" if pmc # copy pmc > cc << podling.private_mail_list if podling # copy podling > mail.cc = cc.uniq > > #<TypeError: no implicit conversion of Mail::Field into Array> > /Users/clr/apache/git/whimsy/www/secmail/views/actions/icla.json.rb:120:in > `block in _evaluate' > /Users/clr/apache/git/whimsy/www/secmail/tasks.rb:9:in `task' > /Users/clr/apache/git/whimsy/www/secmail/views/actions/icla.json.rb:113:in > `_evaluate' > /Users/clr/apache/git/whimsy/www/secmail/server.rb:58:in `block in <top > (required)>' > /usr/local/lib/ruby/gems/2.3.0/gems/passenger-5.0.30/src/ruby_supportlib/phusion_passenger/rack/out_of_band_gc.rb:48:in > `call' > /Users/clr/apache/git/whimsy/lib/whimsy/asf/rack.rb:143:in `call' > /Users/clr/apache/git/whimsy/lib/whimsy/asf/rack.rb:83:in `call' > /Users/clr/apache/git/whimsy/lib/whimsy/asf/rack.rb:217:in `call' > /usr/local/lib/ruby/gems/2.3.0/gems/passenger-5.0.30/src/ruby_supportlib/phusion_passenger/rack/thread_handler_extension.rb:97:in > `process_request' > /usr/local/lib/ruby/gems/2.3.0/gems/passenger-5.0.30/src/ruby_supportlib/phusion_passenger/request_handler/thread_handler.rb:160:in > `accept_and_process_next_request' > /usr/local/lib/ruby/gems/2.3.0/gems/passenger-5.0.30/src/ruby_supportlib/phusion_passenger/request_handler/thread_handler.rb:113:in > `main_loop' > /usr/local/lib/ruby/gems/2.3.0/gems/passenger-5.0.30/src/ruby_supportlib/phusion_passenger/request_handler.rb:416:in > `block (3 levels) in start_threads' > /usr/local/lib/ruby/gems/2.3.0/gems/passenger-5.0.30/src/ruby_supportlib/phusion_passenger/utils.rb:113:in > `block in create_thread_and_abort_on_exception' > >> On Sep 15, 2016, at 10:52 AM, Craig Russell <[email protected]> wrote: >> >> I changed the email address of the icla and the original was not cc: on the >> email. >> >> >> >> > > Craig L Russell > [email protected] > >
