looks like a bug to me.

- Sam Ruby

On Tue, Dec 20, 2016 at 2:32 PM, sebb <[email protected]> wrote:
> PING?
>
> On 8 December 2016 at 18:41, sebb <[email protected]> wrote:
>> Just noticed the following code:
>>
>>     # list of all ids
>>     def self.availids
>>       return [] unless SOURCE
>>       refresh
>>       return @@availids if @@availids
>>       availids = []
>>       each {|icla| availids << icla.id unless icla.id == 'notinavail'}
>>       @availids = availids
>>     end
>>
>> AFAICT that will never set up @@availids, or have I misunderstood?
>> Surely the last line of the function should be:
>>
>>       @@availids = availids

Reply via email to