NM it was a stupid reason on my part why that merge commit even existed.
I've pushed up a fix.

On Thu, Dec 29, 2016 at 8:15 PM John D. Ament <[email protected]> wrote:

> I think its because of the merge commit.  I can rebase to fix that, or
> someone can rebase when merging.
>
>
> On Thu, Dec 29, 2016 at 8:13 PM Craig Russell <[email protected]>
> wrote:
>
> Hi John,
>
> I notice that this PR is relatively small, but what you actually merged is
> YUUUUGE.
>
> Did I miss something or ???
>
> Craig
>
> > On Dec 27, 2016, at 7:55 PM, John D. Ament <[email protected]>
> wrote:
> >
> > Hey just wondering if anyone's around to take a look at my PR?
> >
> > https://github.com/apache/whimsy/pull/16/
> >
> > https://issues.apache.org/jira/browse/WHIMSY-68
> >
> > John
>
> Craig L Russell
> [email protected]
>
>
>

Reply via email to