On 3 April 2017 at 14:58, Sam Ruby <[email protected]> wrote: > On Mon, Apr 3, 2017 at 9:35 AM, Shane Curcuru <[email protected]> wrote: >> Arguably, it seems like this is a bug, because LDAP.configure won't >> add/check for the known good HOSTS to an existing ldap.conf uri entry if >> the user already has a cached .whimsy file with an ldap entry. >> >> Presumably ldap.rb#L212 should better check the HOSTS vs. the value read >> from L157, or at least configure should issue a warning if it's run when >> there's a locally cached value? >> >> We can discuss if this is a bug (because configure should always safely >> update to current servers) or a feature (because we should respect a >> user's specifically stated overrides in .whimsy) if anyone else has >> interest. 8-) > > Can I argue both sides? :-) > > The purpose of configure is to update /etc/ldap.conf or > /etc/openldap.conf depending on your O/S. It did its job. > > However warning you (via Wunderbar.warn) if any of the entries in > hosts (which internally calls ASF::Config.get(:ldap)) is not in > ASF::LDAP::HOSTS might be a very good idea.
+1 It is sometimes useful to be able to override the LDAP server, e.g. to test a failing server. >> -- >> >> - Shane >> https://www.apache.org/foundation/marks/resources > > - Sam Ruby
