> On Apr 18, 2017, at 2:03 AM, sebb <[email protected]> wrote:
>
> On 18 April 2017 at 00:20, Craig Russell <[email protected]> wrote:
>> Let's see if this approach makes sense.
>>
>> If the field 5 data is disabled; <any reason> then one of the following must
>> be true:
>>
>> ASF::Person.find('notsetup') is null or
>> ASF::Person.find('badactor').banned? is true
>>
>> If not, then signal an error 'disabled but account is active'
>
> I think the conditions need different errors.
Why?
> A missing LDAP entry needs separate investigation.
There are currently 16 icla-lint entries where there is an icla and no ldap. I
am not proposing to change this behavior. But if we decide that there is an
icla.txt that should not have an ldap entry it makes sense to me to annotate
the icla.txt with disabled; mumble so we don't need to have it flagged each
time we run icla-lint.
>
>> I can go back into BadActor later and add disabled; mumble
>>
>> I can also annotate BannedMember's entry with disabled; mumble
>
> Should probably also check that LDAP agrees with iclas.txt, e.g. if
> ASF::Person.find('badactor').banned? is true then iclas.txt should be
> flagged disabled and vice versa.
This tool scans iclas.txt and verifies with ldap. I don't think there is
anything that scans ldap and verifies with iclas.txt.
So my proposal for changing the current behavior:
If field 5 is disabled for any reason, verify that ldap is either missing or
banned. I don't see the need to distinguish these two cases.
>
> But in the longer term, why are we maintaining two parallel sets of data?
> Once there is proper logging of LDAP changes, do we still need iclas.txt?
> It has some unique data, but that could presumably be added to LDAP if
> required.
I have no issues if we want to go down that path. I'm just not volunteering to
drive it. ;-)
Craig
>
>> Craig
>>
>>> On Apr 17, 2017, at 10:29 AM, Craig Russell <[email protected]>
>>> wrote:
>>>
>>> Workflow:
>>>
>>> Secretary determines that a replacement icla is not coming.
>>>
>>> Secretary requests infra to disable the account.
>>>
>>> Infra disables the account. How does whimsy know that the account is
>>> disabled?
>>>
>>> Secretary updates iclas.txt with "disabled; no icla on file"
>>>
>>> The icla-lint should be able to reconcile disabled account in LDAP with
>>> disabled account in iclas.txt.
>>>
>>> How should whimsy committer display disabled accounts? Should there be a
>>> date stamp when the account was disabled?
>>>
>>> Craig
>>>
>>>> On Apr 16, 2017, at 5:08 PM, Craig Russell <[email protected]>
>>>> wrote:
>>>>
>>>> Looks like there is agreement with infra that accounts that were created
>>>> and now there is no icla on file should be disabled.
>>>>
>>>> I've asked infra to disable a number of these accounts and I've updated
>>>> iclas.txt to indicate that they are disabled.
>>>>
>>>> If/when the committers show up, it's easy enough to file their iclas and
>>>> get them back to commit status.
>>>>
>>>> Craig
>>>>
>>>>> On Apr 16, 2017, at 11:46 AM, sebb <[email protected]> wrote:
>>>>>
>>>>> On 15 April 2017 at 16:30, Sam Ruby <[email protected]> wrote:
>>>>>> On Sat, Apr 15, 2017 at 11:21 AM, Craig Russell <[email protected]>
>>>>>> wrote:
>>>>>>> So how do we handle this?
>>>>>>>
>>>>>>> We need to remove the iclas.txt entry for edalquist, which I can do
>>>>>>> manually. We also need to remove the LDAP entry, which I do not even
>>>>>>> know how to do.
>>>>>>
>>>>>> Sebb would argue that the ID should be disabled, not removed.
>>>>>
>>>>> Yes, because otherwise the id might be reallocated to someone else.
>>>>> Also we might lose details of code commits.
>>>>>
>>>>>> Whether
>>>>>> it is disabling or removing, currently this authority is reserved by
>>>>>> the infrastructure team to themselves. What could be done is a delete
>>>>>> account request, much like we currently have a create account request.
>>>>>
>>>>> I think deletion is too strong unless it can be shown that the id has
>>>>> never been used for a CVS/SVN/Git commit.
>>>>>
>>>>>> Should the ID be removed, it would also need to be removed from each
>>>>>> group that this individual is a member of:
>>>>>>
>>>>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__whimsy.apache.org_roster_committer_edalquist&d=DwIFaQ&c=RoP1YumCXCgaWHvlZYR8PQcxBKCX5YTpkKY057SbK10&r=DKWhdZdh69Kb6XA85A6vmYASgWIRD5RAywexyAJQArI&m=u29WDved3LSsHM8E1RYtvELY463RxF5Lehe_Xi8C1zc&s=P21mBvHTRxHD8i--NFC7vNrm4TvhTc6Gf81QpxiiINM&e=
>>>>>
>>>>> +1
>>>>>
>>>>>>> Is there a chance we can add a button to the icla-lint whimsy page to
>>>>>>> do both of these?
>>>>>>
>>>>>> I generally shy away from writing code that I don't have the karma to
>>>>>> test. :-)
>>>>>>
>>>>>>> Craig
>>>>>>
>>>>>> - Sam Ruby
>>>>>>
>>>>>>>> Begin forwarded message:
>>>>>>>>
>>>>>>>> From: Eric Dalquist <[email protected]>
>>>>>>>> Subject: Re: Your Apache ICLA has gone missing
>>>>>>>> Date: April 15, 2017 at 8:15:30 AM PDT
>>>>>>>> To: Craig Russell <[email protected]>, [email protected]
>>>>>>>> Cc: Secretary <[email protected]>
>>>>>>>>
>>>>>>>> Thanks for letting me know. Unfortunately my current situation
>>>>>>>> prevents me from submitting an ICLA so I should likely be removed as
>>>>>>>> an eligible Apache committer for now.
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> -Eric Dalquist
>>>>>>>>
>>>>>>>> On Sat, Apr 15, 2017 at 8:09 AM Craig Russell <[email protected]
>>>>>>>> <mailto:[email protected]>> wrote:
>>>>>>>> Dear Eric Dalquist,
>>>>>>>>
>>>>>>>> We are reviewing our records to be sure that all submitted ICLAs are
>>>>>>>> on file.
>>>>>>>> Unfortunately, we are unable to locate the ICLA that you submitted
>>>>>>>> earlier.
>>>>>>>>
>>>>>>>> Can you please resubmit to [email protected]
>>>>>>>> <mailto:[email protected]>?
>>>>>>>> https://urldefense.proofpoint.com/v2/url?u=http-3A__apache.org_licenses_-23submitting&d=DwIFaQ&c=RoP1YumCXCgaWHvlZYR8PQcxBKCX5YTpkKY057SbK10&r=DKWhdZdh69Kb6XA85A6vmYASgWIRD5RAywexyAJQArI&m=u29WDved3LSsHM8E1RYtvELY463RxF5Lehe_Xi8C1zc&s=0x9hY6QUQlsexxFxnFpmkY0MM1ALXTbH1HTk94PXuFY&e=
>>>>>>>>
>>>>>>>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__apache.org_licenses_-23submitting&d=DwMFaQ&c=RoP1YumCXCgaWHvlZYR8PQcxBKCX5YTpkKY057SbK10&r=DKWhdZdh69Kb6XA85A6vmYASgWIRD5RAywexyAJQArI&m=ux3tHihuCCkiz48S9ntTUkM55kdbks51xGLci9BV9jw&s=rMdo3YF1y7PZuxB8_IJVltobKCdVsLlgK1LJCawY5G4&e=>
>>>>>>>> Please do *not* use an apache email as your E-Mail address.
>>>>>>>> You can send the original ICLA (if the email address is still valid)
>>>>>>>> or a new one.
>>>>>>>>
>>>>>>>> Best regards,
>>>>>>>>
>>>>>>>>
>>>>
>>>
>>>
>>
>> Craig L Russell
>> [email protected]
>>
>>
Craig L Russell
Architect
[email protected]
P.S. A good JDO? O, Gasp!