On Fri, Jun 9, 2017 at 11:02 AM, Shane Curcuru <a...@shanecurcuru.org> wrote: > In building the public-orgchart branch, I'd like to ask: > > * whimsy.a.o/orgchart or whimsy.a.o/docs/orgchart or > whimsy.a.o/foundation/orgchart ?
I prefer more specific (foundation) over generic (docs). > * For a code review of some parts before we merge to master: > > https://github.com/apache/whimsy/blob/public-orgchart/www/docs/orgchart.cgi#L66 > Since this cgi will publicly expose bits of formerly private data in > foundation/officers/personnel-duties, can someone double-check that > fields marked 'private' in the .yamls won't leak? I've gone through each page, and it looks right to me. > https://github.com/apache/whimsy/blob/public-orgchart/lib/whimsy/asf/orgchart.rb#L13 > Since this is a private repo, is there anything else we explicitly need > to check before .untaint in this class? ASF::SVN should already untaint this value. If it doesn't, it is a bug in ASF::SVN. > https://github.com/apache/whimsy/blob/public-orgchart/www/docs/orgchart.cgi#L129 > Why doesn't my use of _markdown work, when it seems identical to the one > in www/roster/views/duties.html.rb? I also pushed a small change, enabling markdown. > * Consider changing some of the personnel-duties data structure: > > - The [info] id: field should really be a list, not a string - this > allows the board and infra-staff groups to properly reflect they are > groups of committers, not single individuals. Any objections? That would make this page harder to read: http://whimsy.local/docs/orgchart Perhaps an new field? > * TODO: deprecate www/roster/models/orgchart.rb in favor of > lib/whimsy/asf/orgchart.rb What do you propose for private fields? > -- > > - Shane > https://www.apache.org/foundation/marks/resources - Sam Ruby
