On Thu, Jun 22, 2017 at 6:32 AM, sebb <seb...@gmail.com> wrote: > On 22 June 2017 at 02:36, Sam Ruby <ru...@intertwingly.net> wrote: >> On Wed, Jun 21, 2017 at 7:54 PM, sebb <seb...@gmail.com> wrote: >>> On 22 June 2017 at 00:05, sebb <seb...@gmail.com> wrote: >>>> On 21 June 2017 at 22:21, John D. Ament <johndam...@apache.org> wrote: >>>>> https://whimsy.apache.org/roster/ppmc/pulsar >>>>> >>>>> It shows two members as not on the committers. I got an error the first >>>>> time I did it, then did it from the IPMC screen and it worked without >>>>> error, but now this page isn't reloading. >>>> >>>> Looks like maybe the code is not using the ou=project LDAP correctly >>>> as the names are in the member list for incubator. >>> >>> I found at least one place using the wrong method: >>> >>> https://github.com/apache/whimsy/commit/13640dfc20400c0c188a2c82a6bcc5a4ca66edc1 >>> >>> I think there are more. >> >> Unfortunately, things are changing, and things are stalled. >> >> Once things are complete, the following should no longer be necessary: >> >> https://github.com/apache/whimsy/commit/13a67db920bb5539841b7bf27978b8bc205b1864 >> >> Meanwhile, things are stalled waiting on >> https://issues.apache.org/jira/browse/INFRA-14386. Simply put, I >> don't want to move any more PMCs to the new structure until the new >> account request function updates the correct information. > > But even had that issue already been completed, won't there be a > transitional period when some TLPs use the old code and some the new?
I may not have been clear. When I said "once things are complete", I meant more than that one issue. That issue is revolved, so I will move whimsy over to the new structure, probably later today. This means that cn=whimsy,ou=groups,dc=apache,dc=org will go away. When fully done, cn=*,ou=groups,dc=apache,dc=org will go away. Unfortunately, moving whimsy is not going to tell us much. Every committer to whimsy is an ASF member, so we won't really be testing ponymail for example. Suggestions for other PMCs or other ways to test this before making the change globally would be appreciated. > Also AFAICT the code that references the LDAP groups will still need > to be fixed. > At present the model/view code makes assumptions about how to find > committers and members. > That functionality should be centralised. > > Probably the main code should not refer directly to any of the LDAP > classes (except - perhaps - the public.json scripts) This code definitely could use more refactoring. >>>> Note that Infra recently changed the URL for infra-puppet without >>>> warning; this may have borked things. >>> >>> I don't think that's the case here. >>> >>>> I have updated repository.yml; hopefully that will be sufficient to fix >>>> things. >>>> If not, it may need root karma on Whimsy to sort out. >>>> >>>>> John >> >> - Sam Ruby - Sam Ruby
