On Tue, Jul 18, 2017 at 10:37 AM, Craig Russell <[email protected]> wrote:
> Shouldn't there a subject? e.g. www/board/agenda/views/actions/todos.json.rb 
> line 76.5
>
>     subject "Congratulations on your new role at Apache "

Added:

https://github.com/apache/whimsy/commit/b3318b6199e4e675ad2547b35e7d59824c1cc835

> Thanks,
>
> Craig

- Sam Ruby

>> On Jul 16, 2017, at 7:05 AM, Sam Ruby <[email protected]> wrote:
>>
>> On Thu, Jul 13, 2017 at 8:15 PM, Craig Russell <[email protected]> wrote:
>>>
>>>> On Jul 13, 2017, at 4:28 PM, Sam Ruby <[email protected]> wrote:
>>>>
>>>> On Thu, Jul 13, 2017 at 6:15 PM, Craig Russell <[email protected]> 
>>>> wrote:
>>>>> Hi,
>>>>>
>>>>> There is a function defined in adjournment that should send the 
>>>>> "Congratulations" message to new pmc chairs.
>>>>>
>>>>> What do we (rubys?) need to do to actually send the mail?
>>>>>
>>>>> It should go only to chairs where the "establish pmc" box is ticked.
>>>>
>>>> I've added a button to call that method:
>>>>
>>>> https://github.com/apache/whimsy/commit/3e5639264f69df53cb043d030cfa6b7e81fc8325
>>>>
>>>> You might need to click that button before adding these individuals to
>>>> LDAP, as (if I remember correctly), adding them to LDAP removes them
>>>> from the list of chairs to be added.
>>>>
>>>> Alternately, perhaps this should be a separate list?  The downside to
>>>> a separate list is that you would have to redundantly uncheck
>>>> additions.
>>>
>>> Ideally, the function would be called from the function that adds them to 
>>> LDAP. But if that is not possible, I'd prefer a separate list. Unticking 
>>> additions is not a problem.
>>
>> I've moved the logic there:
>>
>> https://github.com/apache/whimsy/commit/bb9f23f9661ae2a1e15ec1578575d6fbb974f170
>>
>> Note: there is no launch of an email client, the mail is sent directly
>> from the server.
>>
>>> Craig
>>
>> - Sam Ruby
>>
>>>>> Thanks,
>>>>>
>>>>> Craig
>>>>>
>>>>> Craig L Russell
>>>>> Secretary, Apache Software Foundation
>>>>> [email protected] http://db.apache.org/jdo
>>>>
>>>> - Sam Ruby
>>>
>>> Craig L Russell
>>> Architect
>>> [email protected]
>>> P.S. A good JDO? O, Gasp!
>
> Craig L Russell
> Architect
> [email protected]
> P.S. A good JDO? O, Gasp!
>
>
>
>
>

Reply via email to