> On Nov 12, 2017, at 7:08 AM, Sam Ruby <[email protected]> wrote:
>
> On Sat, Nov 11, 2017 at 8:56 PM, Craig Russell <[email protected]> wrote:
>> I'd like to change the logic for the project/icla:
>>
>> Do not allow Members to invite submission of iclas for projects that they
>> are not owners of.
>>
>> Allow all IPMC members to invite submission of iclas for any podlings.
>
> On first blush, these seem inconsistent. My preference is that PPMCs
> be treated as PMCs with mentors.
>
> This leads to two potential alternatives to what you suggest:
>
> 1) only allow [P]PMC members to invite submissions for an ICLA. In
> rare cases, ASF members, IPMC members, or whatever can modify a [P]PMC
> to include themselves so that they can send an invite, and afterwards
> can remove themselves.
I like this alternative. I'm not sure how to implement it. I found the
differences between ASF::Committee and ASF::Podling to be confusing. "All
Podlings are Committees but not all Committees are Podlings".
How would this code change?
# allow user to invite contributors for PMCs of which the user is a member,
# or for podlings if the user is a member of the IPMC or the podling.
user = ASF::Person.find(env.user)
committees = user.committees.map(&:name)
ipmc = committees.include?('incubator')
@pmcs.select! {|pmc| committees.include?(pmc)}
@ppmcs.select! {|ppmc| committees.include?('incubator') |
committees.include?(ppmc)}
Perhaps as simple as:
@ppmcs.select! {|ppmc| committees.include?(ppmc)}
I'm unable to test this, since I'm not a mentor of any podlings at the moment.
Craig
>
> 2) allow members to send invites (and IPMC members to send invites
> for PPMC, though with only a few exceptions, all IPMC members are ASF
> members), relying on notifications to the [P]PMC to ensure that the
> invite is in the interest of the community.
>
> I'm OK with either of these (and not strongly opposed to your original
> suggestion), with my preferred order being 1, 2, 0 (with zero being
> your original suggestion). My reasoning: "let me do that for you"
> misses out on a teachable moment.
>
>> WDYT?
>>
>> Craig
>>
>> Craig L Russell
>> Secretary, Apache Software Foundation
>> [email protected] http://db.apache.org/jdo
>
> - Sam Ruby
Craig L Russell
Secretary, Apache Software Foundation
[email protected] http://db.apache.org/jdo
