I haven't looked at the code itself yet, but here's some user comments. Craig Russell wrote on 1/13/18 12:38 PM: > Please take a look at these pages: > > whimsy.apache.org/project/icla
- Where did you grab the navbar and header layout from? Some of it I really like; the graphics layout not as much. But a larger (and later) discussion should be: should we have a header/footer UX we use for interactive tools across whimsy? I already have a standard header/footer on most of the "show me lists of data" tools (cgi's, mostly), but we're now building neat interactive tools like this, which are a little different from the UX perspective. - Having the edit boxes be red outlined (which implies bad data) to start with is a little odd. But I dunno that it's worth changing that. - Adding form groups or <hr>-ish things between form sections would be nice. I understand the progression once you've chosen the PMC you can then "start the discussion..." but it would be even clearer with better grouping of the different sections. - The email address field validates "test@shane" as a valid email address (requires at least a .ab domain name ending). - Interestingly, I got a ...undefined method 'empty?' for nil class... error and then Safari actually hung for a solid minute when pressing the Preview button... Can't even open the JS console for Safari. Have not yet looked at the code, not enough time yet. But nice overall, and sounds like a great start to real workflow apps. > whimsy.apache.org/project/icla/discuss > whimsy.apache.org/project/icla/vote > > The forms are close to what I would like to ship. There is no processing > behind them. That's next. But I'd really like a review for: > > elegance > content > behavior > maintainability > > There are some really inelegant parts of the forms and code and I'd like to > fix these. > > Don't hold back. > > Craig L Russell > Secretary, Apache Software Foundation > c...@apache.org http://db.apache.org/jdo > -- - Shane https://www.apache.org/foundation/marks/resources
