On Mon, Jan 22, 2018 at 4:38 PM, sebb <[email protected]> wrote: > On 22 January 2018 at 20:47, <[email protected]> wrote: >> This is an automated email from the ASF dual-hosted git repository. >> >> rubys pushed a commit to branch master >> in repository https://gitbox.apache.org/repos/asf/whimsy.git >> >> commit 67b4eb31341a496f98e2519ad5e9934e7acee675 >> Author: Sam Ruby <[email protected]> >> AuthorDate: Mon Jan 22 15:47:43 2018 -0500 >> >> capture latest configuration >> --- >> tools/mkconf.rb | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/tools/mkconf.rb b/tools/mkconf.rb >> index 2be9e74..5a9f32d 100644 >> --- a/tools/mkconf.rb >> +++ b/tools/mkconf.rb >> @@ -20,6 +20,8 @@ conf.sub! 'ServerName whimsy.apache.org', 'ServerName >> whimsy.local' > > I think the ServerAlias entries probably need to be commented or > dropped - agreed?
No objection. Meanwhile, they won't be used unless somebody modifies their /etc/hosts (or equivalent) to point these aliases at themselves. >> conf.gsub! /(\A|\n)\s*RemoteIPHeader.*/, '' >> >> conf.gsub! /\n\s*PassengerDefault.*/, '' >> +conf.gsub! /\n\s*PassengerUser.*/, '' >> +conf.gsub! /\n\s*PassengerGroup.*/, '' > > It might be better to comment the Passenger auth settings instead. > I expect test installations will still need them, even if they vary > between OSes. My intention (captured in the commit I pushed at the same time as this one) was to suggest that this be added to passenger.conf. >> conf.gsub! /\n\s*SSL.*/, '' >> conf.gsub! /\n\s*## SSL.*/, '' >> >> -- >> To stop receiving notification emails like this one, please contact >> [email protected]. > > That email seems wrong! Indeed! - Sam Ruby
