On Mon, Apr 30, 2018 at 1:47 PM, sebb <[email protected]> wrote: > On 30 April 2018 at 02:50, Sam Ruby <[email protected]> wrote: >> On Sun, Apr 29, 2018 at 9:39 PM, sebb <[email protected]> wrote: >>> On 30 April 2018 at 02:26, Sam Ruby <[email protected]> wrote: >>>> On Sun, Apr 29, 2018 at 9:22 PM, sebb <[email protected]> wrote: >>>>> On 30 April 2018 at 01:26, <[email protected]> wrote: >>>>>> This is an automated email from the ASF dual-hosted git repository. >>>>>> >>>>>> rubys pushed a commit to branch master >>>>>> in repository https://gitbox.apache.org/repos/asf/whimsy.git >>>>>> >>>>>> >>>>>> The following commit(s) were added to refs/heads/master by this push: >>>>>> new 986dbb8 add trunk to comdev svn path >>>>> >>>>> Why is Whimsy using comdev source (which may change again) rather than >>>>> the public URLs? >>>>> Does it need data that is not currently published? >>>> >>>> the roster tool is slow enough as it is. :-) >>>> >>>> Accessing data on disk is faster and more reliable than fetching it from a >>>> URL. >>> >>> It's only reliable if the location does not change ... >>> >>> Rather than synching the repo, the data could be fetched and cached. >>> It's currently only committed once a day. >>> The jobs that update the data run between about midnight and about 4am >>> and the commit is around 4:20. >> >> And that fetch would have to have a monitor task. >> >> Location has only changed once in (mumblely mumble) years. If it >> changes again, it is a one line fix. > > It turns out that the URL was used in another file as well...
DOH! I should have caught and fixed that. Thanks! >> But if you feel inclined to make this change, go for it! > > I think it might be more useful to ensure that the code was only > allowed to access SVN and git via the names in repository.yaml. > > e.g. instead of > > ASF::SVN['asf/comdev/projects.apache.org/trunk/site/json/foundation'] > > the code would use something like: > > ASF::SVN.path(base[, path]) > > where base is one of the entries in repository.yaml, i.e. > 'comdev-foundation' in this case. > > Does that sound reasonable? I like the idea. The first step is to allow such. I've committed this change (without the [, path] support - calling code can do this themselves?). I'm not yet sure about requiring that usage - there may be cases in development where other repositories may be used. But migrating existing usages to repository.yml names when it makes sense does seem like a good idea. - Sam Ruby >> - Sam Ruby >> >>>>>> 986dbb8 is described below >>>>>> >>>>>> commit 986dbb82261153afb707cc797d47103aa4d3face >>>>>> Author: Sam Ruby <[email protected]> >>>>>> AuthorDate: Sun Apr 29 20:26:05 2018 -0400 >>>>>> >>>>>> add trunk to comdev svn path >>>>>> --- >>>>>> repository.yml | 2 +- >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/repository.yml b/repository.yml >>>>>> index 89c2ba1..bd6ad78 100644 >>>>>> --- a/repository.yml >>>>>> +++ b/repository.yml >>>>>> @@ -31,7 +31,7 @@ >>>>>> url: private/documents/cclas >>>>>> >>>>>> comdev-foundation: >>>>>> - url: asf/comdev/projects.apache.org/site/json/foundation >>>>>> + url: asf/comdev/projects.apache.org/trunk/site/json/foundation >>>>>> >>>>>> foundation: >>>>>> url: private/foundation >>>>>> >>>>>> -- >>>>>> To stop receiving notification emails like this one, please contact >>>>>> [email protected].
