[ https://issues.apache.org/jira/browse/WHIMSY-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664375#comment-16664375 ]
Sebb commented on WHIMSY-213: ----------------------------- Updated code to handle wrapped message-id headers Also fixed tools/deliver.rb > Secretary workbench message hash is not guaranteed unique > --------------------------------------------------------- > > Key: WHIMSY-213 > URL: https://issues.apache.org/jira/browse/WHIMSY-213 > Project: Whimsy > Issue Type: Bug > Reporter: Sebb > Priority: Major > > The message hash is generated here [1]. > This is not guaranteed unique, as some Message-ID header lines are wrapped; > the unique part is on the next line. > Further, message IDs themselves may not be unique, though this is much less > likely. > Also AFAICT the code can pick up a Message-ID which is in the body of a > message. > If two such messages arrive in the same month, the second will replace the > first. > If the first message has not been handled, AFAICT it won't ever be processed. > [1] > https://github.com/apache/whimsy/blob/9118c9187f5dc234f5c659caf54e90a7301bb4e3/www/secretary/workbench/models/message.rb#L317 -- This message was sent by Atlassian JIRA (v7.6.3#76005)