Sebb created WHIMSY-220:
---------------------------

             Summary: Inconsistent and confusin return from ASF::Service.list 
method
                 Key: WHIMSY-220
                 URL: https://issues.apache.org/jira/browse/WHIMSY-220
             Project: Whimsy
          Issue Type: Bug
            Reporter: Sebb


The ASF::Service.list method returns only the service names, not a list of the 
objects.

This disagrees with all the other list methods in the ldap.rb file.
Further, the Service sub-class ASF::AppGroup overrides the method so it returns 
a list of objects.
However the Service sub-class ASF::AuthGroup does not override list.

This is very confusing.

The list methods should be consistent.

Note that several of the classes in the file which have list() methods also 
have listids() methods which just return the names of the objects.

It would be better if ASF::Service.list were renamed ASF::Service.listids, and 
references to Service.list and AuthGroup.list were updated to use listids() 
where appropriate.

Note: AFAICT the list() methods under discussion are only used in 
roster/model/group.rb currently, so the change would be minor.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to